From: Sudeep Holla <sudeep.holla@arm.com>
To: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
Cc: mark.rutland@arm.com, lorenzo.pieralisi@arm.com,
linux-arm-kernel@lists.infradead.org,
Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH v2] firmware/psci: psci_checker: Park kthreads before stopping them
Date: Tue, 11 Jun 2019 10:42:29 +0100 [thread overview]
Message-ID: <20190611094229.GA6235@e107155-lin> (raw)
In-Reply-To: <20190610173829.4741-1-jean-philippe.brucker@arm.com>
On Mon, Jun 10, 2019 at 06:38:29PM +0100, Jean-Philippe Brucker wrote:
> Since commit 85f1abe0019f ("kthread, sched/wait: Fix kthread_parkme()
> completion issue"), kthreads that are bound to a CPU must be parked
> before being stopped. At the moment the PSCI checker calls
> kthread_stop() directly on the suspend kthread, which triggers the
> following warning:
>
> [ 6.068288] WARNING: CPU: 1 PID: 1 at kernel/kthread.c:398 __kthread_bind_mask+0x20/0x78
> ...
> [ 6.190151] Call trace:
> [ 6.192566] __kthread_bind_mask+0x20/0x78
> [ 6.196615] kthread_unpark+0x74/0x80
> [ 6.200235] kthread_stop+0x44/0x1d8
> [ 6.203769] psci_checker+0x3bc/0x484
> [ 6.207389] do_one_initcall+0x48/0x260
> [ 6.211180] kernel_init_freeable+0x2c8/0x368
> [ 6.215488] kernel_init+0x10/0x100
> [ 6.218935] ret_from_fork+0x10/0x1c
> [ 6.222467] ---[ end trace e05e22863d043cd3 ]---
>
> kthread_unpark() tries to bind the thread to its CPU and aborts with a
> WARN() if the thread wasn't in TASK_PARKED state. Park the kthreads
> before stopping them.
>
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-11 9:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 17:38 [PATCH v2] firmware/psci: psci_checker: Park kthreads before stopping them Jean-Philippe Brucker
2019-06-11 9:42 ` Sudeep Holla [this message]
2019-06-11 10:48 ` Lorenzo Pieralisi
2019-06-17 11:51 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190611094229.GA6235@e107155-lin \
--to=sudeep.holla@arm.com \
--cc=jean-philippe.brucker@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.