From: Mike Snitzer <snitzer@redhat.com>
To: Pankaj Gupta <pagupta@redhat.com>
Cc: cohuck@redhat.com, jack@suse.cz, kvm@vger.kernel.org,
mst@redhat.com, david@fromorbit.com, qemu-devel@nongnu.org,
virtualization@lists.linux-foundation.org, dm-devel@redhat.com,
adilger.kernel@dilger.ca, zwisler@kernel.org,
aarcange@redhat.com, dave.jiang@intel.com, jstaron@google.com,
linux-nvdimm@lists.01.org, vishal.l.verma@intel.com,
willy@infradead.org, hch@infradead.org,
linux-acpi@vger.kernel.org, jmoyer@redhat.com,
linux-ext4@vger.kernel.org, lenb@kernel.org, kilobyte@angband.pl,
rdunlap@infradead.org, riel@surriel.com, yuval.shaia@oracle.com,
stefanha@redhat.com, pbonzini@redhat.com,
dan.j.williams@intel.com, lcapitulino@redhat.com,
nilal@redhat.com, tytso@mit.edu, xiaoguangrong.eric@gmail.com,
darrick.wong@oracle.com, rjw@rjwysocki.net,
linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, imammedo@redhat.com
Subject: Re: [PATCH v12 4/7] dm: enable synchronous dax
Date: Tue, 11 Jun 2019 13:14:17 -0400 [thread overview]
Message-ID: <20190611171416.GA1248__40886.5673163504$1560273309$gmane$org@redhat.com> (raw)
In-Reply-To: <20190611163802.25352-5-pagupta@redhat.com>
On Tue, Jun 11 2019 at 12:37pm -0400,
Pankaj Gupta <pagupta@redhat.com> wrote:
> This patch sets dax device 'DAXDEV_SYNC' flag if all the target
> devices of device mapper support synchrononous DAX. If device
> mapper consists of both synchronous and asynchronous dax devices,
> we don't set 'DAXDEV_SYNC' flag.
>
> 'dm_table_supports_dax' is refactored to pass 'iterate_devices_fn'
> as argument so that the callers can pass the appropriate functions.
>
> Suggested-by: Mike Snitzer <snitzer@redhat.com>
> Signed-off-by: Pankaj Gupta <pagupta@redhat.com>
Thanks, and for the benefit of others, passing function pointers like
this is perfectly fine IMHO because this code is _not_ in the fast
path. These methods are only for device creation.
Reviewed-by: Mike Snitzer <snitzer@redhat.com>
next prev parent reply other threads:[~2019-06-11 17:14 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 16:37 [PATCH v12 0/7] virtio pmem driver Pankaj Gupta
2019-06-11 16:37 ` Pankaj Gupta
2019-06-11 16:37 ` [Qemu-devel] " Pankaj Gupta
2019-06-11 16:37 ` Pankaj Gupta
2019-06-11 16:37 ` [PATCH v12 1/7] libnvdimm: nd_region flush callback support Pankaj Gupta
2019-06-11 16:37 ` Pankaj Gupta
2019-06-11 16:37 ` [Qemu-devel] " Pankaj Gupta
2019-06-11 16:37 ` Pankaj Gupta
2019-06-11 16:37 ` [PATCH v12 2/7] virtio-pmem: Add virtio pmem driver Pankaj Gupta
2019-06-11 16:37 ` Pankaj Gupta
2019-06-11 16:37 ` [Qemu-devel] " Pankaj Gupta
2019-06-11 16:37 ` Pankaj Gupta
2019-06-11 17:02 ` Cornelia Huck
2019-06-11 17:02 ` Cornelia Huck
2019-06-11 17:02 ` [Qemu-devel] " Cornelia Huck
2019-06-11 17:02 ` Cornelia Huck
2019-06-12 3:34 ` Pankaj Gupta
2019-06-12 3:34 ` Pankaj Gupta
2019-06-12 3:34 ` [Qemu-devel] " Pankaj Gupta
2019-06-12 3:34 ` Pankaj Gupta
2019-06-12 6:37 ` Cornelia Huck
2019-06-12 6:37 ` Cornelia Huck
2019-06-12 6:37 ` [Qemu-devel] " Cornelia Huck
2019-06-12 6:37 ` Cornelia Huck
2019-06-12 10:50 ` [Qemu-devel] " Pankaj Gupta
2019-06-12 10:50 ` Pankaj Gupta
2019-06-12 10:50 ` Pankaj Gupta
2019-06-12 10:50 ` Pankaj Gupta
2019-06-12 10:50 ` Pankaj Gupta
2019-06-12 6:37 ` Cornelia Huck
2019-06-12 3:34 ` Pankaj Gupta
2019-06-11 17:02 ` Cornelia Huck
2019-06-11 16:37 ` [PATCH v12 3/7] libnvdimm: add dax_dev sync flag Pankaj Gupta
2019-06-11 16:37 ` Pankaj Gupta
2019-06-11 16:37 ` [Qemu-devel] " Pankaj Gupta
2019-06-11 16:37 ` Pankaj Gupta
2019-06-11 16:37 ` [PATCH v12 4/7] dm: enable synchronous dax Pankaj Gupta
2019-06-11 16:37 ` Pankaj Gupta
2019-06-11 16:37 ` [Qemu-devel] " Pankaj Gupta
2019-06-11 16:37 ` Pankaj Gupta
2019-06-11 17:14 ` Mike Snitzer [this message]
2019-06-11 17:14 ` Mike Snitzer
2019-06-11 17:14 ` Mike Snitzer
2019-06-11 17:14 ` [Qemu-devel] " Mike Snitzer
2019-06-11 17:14 ` Mike Snitzer
2019-06-12 2:23 ` [Qemu-devel] " Pankaj Gupta
2019-06-12 2:23 ` Pankaj Gupta
2019-06-12 2:23 ` Pankaj Gupta
2019-06-12 2:23 ` Pankaj Gupta
2019-06-12 2:23 ` Pankaj Gupta
2019-06-11 16:38 ` [PATCH v12 5/7] dax: check synchronous mapping is supported Pankaj Gupta
2019-06-11 16:38 ` Pankaj Gupta
2019-06-11 16:38 ` [Qemu-devel] " Pankaj Gupta
2019-06-11 16:38 ` Pankaj Gupta
2019-06-11 16:38 ` [PATCH v12 6/7] ext4: disable map_sync for async flush Pankaj Gupta
2019-06-11 16:38 ` [Qemu-devel] " Pankaj Gupta
2019-06-11 16:38 ` Pankaj Gupta
2019-06-11 16:38 ` Pankaj Gupta
2019-06-11 16:38 ` [PATCH v12 7/7] xfs: " Pankaj Gupta
2019-06-11 16:38 ` Pankaj Gupta
2019-06-11 16:38 ` [Qemu-devel] " Pankaj Gupta
2019-06-11 16:38 ` Pankaj Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20190611171416.GA1248__40886.5673163504$1560273309$gmane$org@redhat.com' \
--to=snitzer@redhat.com \
--cc=aarcange@redhat.com \
--cc=adilger.kernel@dilger.ca \
--cc=cohuck@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=darrick.wong@oracle.com \
--cc=dave.jiang@intel.com \
--cc=david@fromorbit.com \
--cc=dm-devel@redhat.com \
--cc=hch@infradead.org \
--cc=imammedo@redhat.com \
--cc=jack@suse.cz \
--cc=jmoyer@redhat.com \
--cc=jstaron@google.com \
--cc=kilobyte@angband.pl \
--cc=kvm@vger.kernel.org \
--cc=lcapitulino@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mst@redhat.com \
--cc=nilal@redhat.com \
--cc=pagupta@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rdunlap@infradead.org \
--cc=riel@surriel.com \
--cc=rjw@rjwysocki.net \
--cc=stefanha@redhat.com \
--cc=tytso@mit.edu \
--cc=virtualization@lists.linux-foundation.org \
--cc=vishal.l.verma@intel.com \
--cc=willy@infradead.org \
--cc=xiaoguangrong.eric@gmail.com \
--cc=yuval.shaia@oracle.com \
--cc=zwisler@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.