Re: [PATCH libdrm v2 4/4] meson.build: Fix meson script on FreeBSD

From: Eric Engestrom <eric.engestrom@intel.com>
To: Niclas Zeising <zeising@daemonic.se>
Cc: Emil Velikov <emil.l.velikov@gmail.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH libdrm v2 4/4] meson.build: Fix meson script on FreeBSD
Date: Mon, 17 Jun 2019 14:44:41 +0100	[thread overview]
Message-ID: <20190617134441.nxzbjxozlfe6v46s@intel.com> (raw)
In-Reply-To: <ca1171ab-ebbe-23f2-15c7-552bbf6aaf38@daemonic.se>

On Monday, 2019-06-17 11:20:43 +0200, Niclas Zeising wrote:
> On 2019-06-17 11:14, Eric Engestrom wrote:
> > On Sunday, 2019-06-16 14:23:43 +0100, Emil Velikov wrote:
> > > From: Niclas Zeising <zeising@daemonic.se>
> > > 
> > > FreeBSD requires sys/types.h for sys/sysctl.h, add it as part of the
> > > includes when checking for headers.
> > > Instead of splitting out the check for sys/sysctl.h from the other
> > > header checks, just add sys/types.h to all header checks.
> > > 
> > > v2 [Emil]
> > >   - add inline comment
> > >   - drop bash/sh hunk
> > > 
> > > Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
> > 
> > Series is:
> > Reviewed-by: Eric Engestrom <eric.engestrom@intel.com>
> > 
> > But I agree with Emil, it's a FreeBSD bug for it to not include
> > a required header, this should also be fixed upstream.
> 
> I'm not sure if my e-mails are getting to the mailing list.

They are :)

You can check the archive if you're not sure:
https://lists.freedesktop.org/archives/dri-devel/2019-June/thread.html

> This is the way
> it's documented in FreeBSD, and there is a lot of legacy reasons it is this
> way.  I doubt it will change, and even if it does, there will be about 5
> years of transition period before all supported releases has the change,
> most likely.
> 
> This is the first time, to my knowledge, this issue has come up.
> 
> (I'm not saying I disagree with you, just saying it's probably easier to
> patch here rather than try to change upstream.)
> 
> Regards
> -- 
> Niclas

If think we both agree then ;)
I definitely agree with should have the workaround downstream, all
I meant is that it's worth pushing upstream to fix the bug so that
*eventually* not all downstream users needs to have the workaround (but
yeah, that will take years to reach).
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel