All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Zhu Yingjiang <yingjiang.zhu@linux.intel.com>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org,
	Mark Brown <broonie@kernel.org>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: Applied "ASoC: SOF: Intel: hda: use the defined stop chip in suspend" to the asoc tree
Date: Mon, 17 Jun 2019 16:24:20 +0100 (BST)	[thread overview]
Message-ID: <20190617152420.87999440046@finisterre.sirena.org.uk> (raw)
In-Reply-To: <20190612172347.22338-13-pierre-louis.bossart@linux.intel.com>

The patch

   ASoC: SOF: Intel: hda: use the defined stop chip in suspend

has been applied to the asoc tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.3

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 9a50ee58b8b11300788d41cd1c0f370833424823 Mon Sep 17 00:00:00 2001
From: Zhu Yingjiang <yingjiang.zhu@linux.intel.com>
Date: Wed, 12 Jun 2019 12:23:44 -0500
Subject: [PATCH] ASoC: SOF: Intel: hda: use the defined stop chip in suspend

Unify suspend code by using SOF common function
hda_dsp_ctrl_stop_chip() which can handle both HDA
and non-HDA cases.

Signed-off-by: Zhu Yingjiang <yingjiang.zhu@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/sof/intel/hda-dsp.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/sound/soc/sof/intel/hda-dsp.c b/sound/soc/sof/intel/hda-dsp.c
index 883134d535b3..f2c5a12db930 100644
--- a/sound/soc/sof/intel/hda-dsp.c
+++ b/sound/soc/sof/intel/hda-dsp.c
@@ -311,15 +311,8 @@ static int hda_suspend(struct snd_sof_dev *sdev, int state)
 	hda_dsp_ctrl_ppcap_enable(sdev, false);
 	hda_dsp_ctrl_ppcap_int_enable(sdev, false);
 
-#if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA)
-	/* disable hda bus irq and i/o */
-	snd_hdac_bus_stop_chip(bus);
-#else
-	/* disable hda bus irq */
-	snd_sof_dsp_update_bits(sdev, HDA_DSP_HDA_BAR, SOF_HDA_INTCTL,
-				SOF_HDA_INT_CTRL_EN | SOF_HDA_INT_GLOBAL_EN,
-				0);
-#endif
+	/* disable hda bus irq and streams */
+	hda_dsp_ctrl_stop_chip(sdev);
 
 	/* disable LP retention mode */
 	snd_sof_pci_update_bits(sdev, PCI_PGCTL,
-- 
2.20.1

  reply	other threads:[~2019-06-17 15:24 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-12 17:23 [PATCH 00/15] ASoC: SOF: Intel: HDaudio fixes and improvements Pierre-Louis Bossart
2019-06-12 17:23 ` [PATCH 01/15] ASoC: SOF: Intel: hda: save handle to sdev in sof_intel_hda_stream Pierre-Louis Bossart
2019-06-13  8:00   ` Amadeusz Sławiński
2019-06-17 15:24   ` Applied "ASoC: SOF: Intel: hda: save handle to sdev in sof_intel_hda_stream" to the asoc tree Mark Brown
2019-06-12 17:23 ` [PATCH 02/15] ASoC: SOF: Intel: hda: add new macro hstream_to_sof_hda_stream() Pierre-Louis Bossart
2019-06-17 15:24   ` Applied "ASoC: SOF: Intel: hda: add new macro hstream_to_sof_hda_stream()" to the asoc tree Mark Brown
2019-06-12 17:23 ` [PATCH 03/15] ASoC: SOF: topology: add cpu_dai_name for DAIs Pierre-Louis Bossart
2019-06-17 15:24   ` Applied "ASoC: SOF: topology: add cpu_dai_name for DAIs" to the asoc tree Mark Brown
2019-06-12 17:23 ` [PATCH 04/15] ASoC: SOF: Intel: hda: assign link DMA channel at run-time Pierre-Louis Bossart
2019-06-17 15:24   ` Applied "ASoC: SOF: Intel: hda: assign link DMA channel at run-time" to the asoc tree Mark Brown
2019-06-12 17:23 ` [PATCH 05/15] ASoC: SOF: Intel: hda: reserve host DMA channel for hostless streams Pierre-Louis Bossart
2019-06-17 15:24   ` Applied "ASoC: SOF: Intel: hda: reserve host DMA channel for hostless streams" to the asoc tree Mark Brown
2019-06-12 17:23 ` [PATCH 06/15] ASoC: SOF: Intel: hda: release link DMA for paused streams during suspend Pierre-Louis Bossart
2019-06-17 15:24   ` Applied "ASoC: SOF: Intel: hda: release link DMA for paused streams during suspend" to the asoc tree Mark Brown
2019-06-12 17:23 ` [PATCH 07/15] ASoC: SOF: Intel: hda: couple host and link DMA during FE hw_free Pierre-Louis Bossart
2019-06-17 15:24   ` Applied "ASoC: SOF: Intel: hda: couple host and link DMA during FE hw_free" to the asoc tree Mark Brown
2019-06-12 17:23 ` [PATCH 08/15] ASoC: SOF: Intel: hda: modify stream interrupt handler Pierre-Louis Bossart
2019-06-17 15:24   ` Applied "ASoC: SOF: Intel: hda: modify stream interrupt handler" to the asoc tree Mark Brown
2019-06-12 17:23 ` [PATCH 09/15] ASoC: SOF: Intel: hda-stream: fix a deadlock with bus->reg_lock Pierre-Louis Bossart
2019-06-17 15:24   ` Applied "ASoC: SOF: Intel: hda-stream: fix a deadlock with bus->reg_lock" to the asoc tree Mark Brown
2019-06-12 17:23 ` [PATCH 10/15] ASoC: SOF: Intel: hda: use the SOF defined ppcap functions Pierre-Louis Bossart
2019-06-17 15:24   ` Applied "ASoC: SOF: Intel: hda: use the SOF defined ppcap functions" to the asoc tree Mark Brown
2019-06-12 17:23 ` [PATCH 11/15] ASoC: SOF: Intel: hda: add function for hda stop chip Pierre-Louis Bossart
2019-06-17 15:24   ` Applied "ASoC: SOF: Intel: hda: add function for hda stop chip" to the asoc tree Mark Brown
2019-06-12 17:23 ` [PATCH 12/15] ASoC: SOF: Intel: hda: use the defined stop chip in suspend Pierre-Louis Bossart
2019-06-17 15:24   ` Mark Brown [this message]
2019-06-12 17:23 ` [PATCH 13/15] ASoC: SOF: Intel: hda: clear stream status and wakests properly Pierre-Louis Bossart
2019-06-17 15:24   ` Applied "ASoC: SOF: Intel: hda: clear stream status and wakests properly" to the asoc tree Mark Brown
2019-06-12 17:23 ` [PATCH 14/15] ASoC: SOF: Intel: hda: make sure DMA is start/stop by read the RUN bit Pierre-Louis Bossart
2019-06-17 15:24   ` Applied "ASoC: SOF: Intel: hda: make sure DMA is start/stop by read the RUN bit" to the asoc tree Mark Brown
2019-06-12 17:23 ` [PATCH 15/15] ASoC: SOF: Intel: hda: make sure RUN bit setting to 0 during clear stream status Pierre-Louis Bossart
2019-06-17 15:24   ` Applied "ASoC: SOF: Intel: hda: make sure RUN bit setting to 0 during clear stream status" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190617152420.87999440046@finisterre.sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.de \
    --cc=yingjiang.zhu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.