Re: PCI/AER sysfs files violate the rules of how sysfs works

From: Greg KH <gregkh@linuxfoundation.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Rajat Jain <rajatja@google.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: PCI/AER sysfs files violate the rules of how sysfs works
Date: Fri, 21 Jun 2019 16:44:59 +0200	[thread overview]
Message-ID: <20190621144459.GA6493@kroah.com> (raw)
In-Reply-To: <20190621141550.GG82584@google.com>

On Fri, Jun 21, 2019 at 09:15:50AM -0500, Bjorn Helgaas wrote:
> On Fri, Jun 21, 2019 at 09:29:11AM +0200, Greg KH wrote:
> > Hi,
> > 
> > When working on some documentation scripts to show the
> > Documentation/ABI/ files in an automated way, I ran across this "gem" of
> > a sysfs file: Documentation/ABI/testing/sysfs-bus-pci-devices-aer_stats
> > 
> > In it you describe how the files
> > /sys/bus/pci/devices/<dev>/aer_dev_correctable and
> > /sys/bus/pci/devices/<dev>/aer_dev_fatal and
> > /sys/bus/pci/devices/<dev>/aer_dev_nonfatal
> > all display a bunch of text on multiple lines.
> > 
> > This violates the "one value per sysfs file" rule, and should never have
> > been merged as-is :(
> > 
> > Please fix it up to be a lot of individual files if your really need all
> > of those different values.
> 
> Sorry about that.  Do you think we're safe in changing the sysfs ABI
> by removing the original files and replacing them with new, better
> ones?

I doubt any tool is parsing that monstrosity, so you should be fine :)

> This is pretty new and hopefully not widely used yet.

Only one way to find out...

thanks,

greg k-h