Re: [Qemu-devel] [PULL 0/6] Vga 20190628 patches

From: Gerd Hoffmann <kraxel@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Corey Minyard <cminyard@mvista.com>,
	qemu-arm <qemu-arm@nongnu.org>, qemu-ppc <qemu-ppc@nongnu.org>,
	QEMU Developers <qemu-devel@nongnu.org>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PULL 0/6] Vga 20190628 patches
Date: Tue, 2 Jul 2019 18:48:35 +0200	[thread overview]
Message-ID: <20190702164835.3lnefzrbimltb2h6@sirius.home.kraxel.org> (raw)
In-Reply-To: <CAFEAcA8W6OkDa8cY-YWq7dFeFoZENFiEPNfB3Hy3XQPe6GN2rw@mail.gmail.com>

On Tue, Jul 02, 2019 at 02:47:12PM +0100, Peter Maydell wrote:
> On Tue, 2 Jul 2019 at 10:17, Peter Maydell <peter.maydell@linaro.org> wrote:
> >
> > On Fri, 28 Jun 2019 at 11:40, Gerd Hoffmann <kraxel@redhat.com> wrote:
> > >
> > > The following changes since commit 474f3938d79ab36b9231c9ad3b5a9314c2aeacde:
> > >
> > >   Merge remote-tracking branch 'remotes/amarkovic/tags/mips-queue-jun-21-2019' into staging (2019-06-21 15:40:50 +0100)
> > >
> > > are available in the Git repository at:
> > >
> > >   git://git.kraxel.org/qemu tags/vga-20190628-pull-request
> > >
> > > for you to fetch changes up to 263807f4e85e94f2d4e988d61d2fc0319b1dd36b:
> > >
> > >   ati-vga: switch to vgabios-ati.bin (2019-06-28 10:49:36 +0200)
> > >
> > > ----------------------------------------------------------------
> > > vga: ati fixes, add ati vgabios.
> > >
> > > ----------------------------------------------------------------
> > >
> > > BALATON Zoltan (3):
> > >   i2c: Move bitbang_i2c.h to include/hw/i2c/
> > >   ati-vga: Implement DDC and EDID info from monitor
> > >   ati-vga: Fixes to offset and pitch registers
> > >
> > > Gerd Hoffmann (3):
> > >   seabios: add config for ati vgabios
> > >   seabios: add ati vgabios binary
> > >   ati-vga: switch to vgabios-ati.bin
> > >
> >
> > Applied, thanks.
> >
> > Please update the changelog at https://wiki.qemu.org/ChangeLog/4.1
> > for any user-visible changes.
> 
> Hmm, the bitbang-i2c changes in this pull seem to have broken
> patchew's asan build:
> https://patchew.org/logs/20190628103957.9504-1-kraxel@redhat.com/testing.asan/?type=message
> 
> (probably because now we're using and testing the buggy
> code in a way we weren't before)

Hmm.  Yes, gpio_i2c_init() allocates memory (in inlined
bitbang_i2c_init).  There is no exit() function so the
memory is never freed indeed.  On the other hand i2c
devices are not really hotpluggable, so maybe we only
need to tag it that way?

cheers,
  Gerd