From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Hook, Gary" <Gary.Hook@amd.com>
Cc: "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"Lendacky, Thomas" <Thomas.Lendacky@amd.com>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH v2] crypto: ccp - Validate the the error value used to index error messages
Date: Wed, 3 Jul 2019 22:28:38 +0800 [thread overview]
Message-ID: <20190703142838.f6eszypus7yu62h3@gondor.apana.org.au> (raw)
In-Reply-To: <156165202737.28135.12079221811780949916.stgit@taos>
On Thu, Jun 27, 2019 at 04:16:23PM +0000, Hook, Gary wrote:
> The error code read from the queue status register is only 6 bits wide,
> but we need to verify its value is within range before indexing the error
> messages.
>
> Fixes: 81422badb3907 ("crypto: ccp - Make syslog errors human-readable")
>
> Reported-by: Cfir Cohen <cfir@google.com>
> Signed-off-by: Gary R Hook <gary.hook@amd.com>
> ---
>
> Changes since v1:
> - change parameter type to unsigned int and remove a check
>
> drivers/crypto/ccp/ccp-dev.c | 96 ++++++++++++++++++++++--------------------
> drivers/crypto/ccp/ccp-dev.h | 2 -
> 2 files changed, 52 insertions(+), 46 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2019-07-03 14:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 16:16 [PATCH v2] crypto: ccp - Validate the the error value used to index error messages Hook, Gary
2019-07-03 14:28 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703142838.f6eszypus7yu62h3@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=Gary.Hook@amd.com \
--cc=Thomas.Lendacky@amd.com \
--cc=davem@davemloft.net \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.