From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: YueHaibing <yuehaibing@huawei.com>, kishon@ti.com
Cc: bhelgaas@google.com, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] PCI: dwc: pci-dra7xx: Add missing include file
Date: Fri, 5 Jul 2019 16:29:05 +0100 [thread overview]
Message-ID: <20190705152905.GA6284@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <20190614154044.4972-1-yuehaibing@huawei.com>
On Fri, Jun 14, 2019 at 11:40:44PM +0800, YueHaibing wrote:
> Fix build error:
>
> drivers/pci/controller/dwc/pci-dra7xx.c:
> In function dra7xx_pcie_probe:
> drivers/pci/controller/dwc/pci-dra7xx.c:777:10:
> error: implicit declaration of function devm_gpiod_get_optional;
> did you mean devm_regulator_get_optional? [-Werror=implicit-function-declaration]
>
> reset = devm_gpiod_get_optional(dev, NULL, GPIOD_OUT_HIGH);
Adding the reason (in particular the config options) that triggers
this error would not hurt.
Kishon please let me know if I can merge it (ACK it if so).
Thanks,
Lorenzo
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/pci/controller/dwc/pci-dra7xx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c
> index 419451e..4234ddb 100644
> --- a/drivers/pci/controller/dwc/pci-dra7xx.c
> +++ b/drivers/pci/controller/dwc/pci-dra7xx.c
> @@ -26,6 +26,7 @@
> #include <linux/types.h>
> #include <linux/mfd/syscon.h>
> #include <linux/regmap.h>
> +#include <linux/gpio/consumer.h>
>
> #include "../../pci.h"
> #include "pcie-designware.h"
> --
> 2.7.4
>
>
next prev parent reply other threads:[~2019-07-05 15:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 15:40 [PATCH] PCI: dwc: pci-dra7xx: Add missing include file YueHaibing
2019-06-14 15:40 ` YueHaibing
2019-07-05 15:29 ` Lorenzo Pieralisi [this message]
2019-07-09 11:22 ` Kishon Vijay Abraham I
2019-07-09 11:22 ` Kishon Vijay Abraham I
2019-07-09 16:45 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190705152905.GA6284@e121166-lin.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=bhelgaas@google.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.