Re: [PATCH] fTPM: fix PTR_ERR() usage

From: Sasha Levin <sashal@kernel.org>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Peter Huewe <peterhuewe@gmx.de>,
	Thirupathaiah Annapureddy <thiruan@microsoft.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fTPM: fix PTR_ERR() usage
Date: Sat, 13 Jul 2019 11:10:59 -0400	[thread overview]
Message-ID: <20190713151059.GG10104@sasha-vm> (raw)
In-Reply-To: <730715760b20d9a76aa93c3ebc39a62045c9ee34.camel@linux.intel.com>

On Fri, Jul 12, 2019 at 06:34:24PM +0300, Jarkko Sakkinen wrote:
>On Fri, 2019-07-12 at 13:49 +0200, Arnd Bergmann wrote:
>> A last minute change must have confused PTR_ERR() and ERR_PTR():
>>
>> drivers/char/tpm/tpm_ftpm_tee.c:236:15: error: incompatible pointer to integer
>> conversion passing 'struct tee_context *' to parameter of type 'long' [-
>> Werror,-Wint-conversion]
>>                 if (ERR_PTR(pvt_data->ctx) == -ENOENT)
>> drivers/char/tpm/tpm_ftpm_tee.c:239:18: error: incompatible pointer to integer
>> conversion passing 'struct tee_context *' to parameter of type 'long' [-
>> Werror,-Wint-conversion]
>>                 return ERR_PTR(pvt_data->ctx);
>>
>> Fixes: c975c3911cc2 ("fTPM: firmware TPM running in TEE")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
>Arnd, thanks.
>
>I squashed this to the associated commit.
>
>I also fine-tuned the commit messages a bit (tag, imperative form).

Yes, thank you!

>Started also wondering tha tpm_ftpm_tee is a too generic name given that
>this is for ARM TZ only. Would it make sense to rename it as something
>like tpm_ftpm_tee_arm? Other proposals are welcome. Just made something
>up.

Hm, isn't the _tee part enough?

--
Thanks,
Sasha