Re: [Xen-devel] [PATCH v3 10/14] AMD/IOMMU: allow enabling with IRQ not yet set up

From: "Woods, Brian" <Brian.Woods@amd.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"Woods,  Brian" <Brian.Woods@amd.com>,
	"Suthikulpanit, Suravee" <Suravee.Suthikulpanit@amd.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [Xen-devel] [PATCH v3 10/14] AMD/IOMMU: allow enabling with IRQ not yet set up
Date: Fri, 19 Jul 2019 18:38:42 +0000	[thread overview]
Message-ID: <20190719183839.GH4496@amd.com> (raw)
In-Reply-To: <a2548d39-29c2-1afd-619d-ace67c4d61d6@suse.com>

On Tue, Jul 16, 2019 at 04:39:34PM +0000, Jan Beulich wrote:
> Early enabling (to enter x2APIC mode) requires deferring of the IRQ
> setup. Code to actually do that setup in the x2APIC case will get added
> subsequently.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

Acked-by: Brian Woods <brian.woods@amd.com>

> ---
> v3: Re-base.
> 
> --- a/xen/drivers/passthrough/amd/iommu_init.c
> +++ b/xen/drivers/passthrough/amd/iommu_init.c
> @@ -814,7 +814,6 @@ static void amd_iommu_erratum_746_workar
>   static void enable_iommu(struct amd_iommu *iommu)
>   {
>       unsigned long flags;
> -    struct irq_desc *desc;
>   
>       spin_lock_irqsave(&iommu->lock, flags);
>   
> @@ -834,19 +833,27 @@ static void enable_iommu(struct amd_iomm
>       if ( iommu->features.flds.ppr_sup )
>           register_iommu_ppr_log_in_mmio_space(iommu);
>   
> -    desc = irq_to_desc(iommu->msi.irq);
> -    spin_lock(&desc->lock);
> -    set_msi_affinity(desc, NULL);
> -    spin_unlock(&desc->lock);
> +    if ( iommu->msi.irq > 0 )
> +    {
> +        struct irq_desc *desc = irq_to_desc(iommu->msi.irq);
> +
> +        spin_lock(&desc->lock);
> +        set_msi_affinity(desc, NULL);
> +        spin_unlock(&desc->lock);
> +    }
>   
>       amd_iommu_msi_enable(iommu, IOMMU_CONTROL_ENABLED);
>   
>       set_iommu_ht_flags(iommu);
>       set_iommu_command_buffer_control(iommu, IOMMU_CONTROL_ENABLED);
> -    set_iommu_event_log_control(iommu, IOMMU_CONTROL_ENABLED);
>   
> -    if ( iommu->features.flds.ppr_sup )
> -        set_iommu_ppr_log_control(iommu, IOMMU_CONTROL_ENABLED);
> +    if ( iommu->msi.irq > 0 )
> +    {
> +        set_iommu_event_log_control(iommu, IOMMU_CONTROL_ENABLED);
> +
> +        if ( iommu->features.flds.ppr_sup )
> +            set_iommu_ppr_log_control(iommu, IOMMU_CONTROL_ENABLED);
> +    }
>   
>       if ( iommu->features.flds.gt_sup )
>           set_iommu_guest_translation_control(iommu, IOMMU_CONTROL_ENABLED);
> 

-- 
Brian Woods

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel