From: Vinod Koul <vkoul@kernel.org>
To: Andy Gross <agross@kernel.org>
Cc: linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 5/5] arm64: dts: qcom: sdm845-cheza: remove macro from unit name
Date: Mon, 22 Jul 2019 18:04:22 +0530 [thread overview]
Message-ID: <20190722123422.4571-6-vkoul@kernel.org> (raw)
In-Reply-To: <20190722123422.4571-1-vkoul@kernel.org>
Unit name is supposed to be a number, using a macro with hex value is
not recommended, so add the value in unit name.
arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi:966.16-969.4: Warning (unit_address_format): /soc@0/spmi@c440000/pmic@0/adc@3100/adc-chan@0x4d: unit name should not have leading "0x"
arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi:971.16-974.4: Warning (unit_address_format): /soc@0/spmi@c440000/pmic@0/adc@3100/adc-chan@0x4e: unit name should not have leading "0x"
arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi:976.16-979.4: Warning (unit_address_format): /soc@0/spmi@c440000/pmic@0/adc@3100/adc-chan@0x4f: unit name should not have leading "0x"
arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi:981.16-984.4: Warning (unit_address_format): /soc@0/spmi@c440000/pmic@0/adc@3100/adc-chan@0x50: unit name should not have leading "0x"
arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi:986.16-989.4: Warning (unit_address_format): /soc@0/spmi@c440000/pmic@0/adc@3100/adc-chan@0x51: unit name should not have leading "0x"
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
index 1ebbd568dfd7..9b27b8346ba1 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi
@@ -963,27 +963,27 @@ ap_ts_i2c: &i2c14 {
};
&pm8998_adc {
- adc-chan@ADC5_AMUX_THM1_100K_PU {
+ adc-chan@4d {
reg = <ADC5_AMUX_THM1_100K_PU>;
label = "sdm_temp";
};
- adc-chan@ADC5_AMUX_THM2_100K_PU {
+ adc-chan@4e {
reg = <ADC5_AMUX_THM2_100K_PU>;
label = "quiet_temp";
};
- adc-chan@ADC5_AMUX_THM3_100K_PU {
+ adc-chan@4f {
reg = <ADC5_AMUX_THM3_100K_PU>;
label = "lte_temp_1";
};
- adc-chan@ADC5_AMUX_THM4_100K_PU {
+ adc-chan@50 {
reg = <ADC5_AMUX_THM4_100K_PU>;
label = "lte_temp_2";
};
- adc-chan@ADC5_AMUX_THM5_100K_PU {
+ adc-chan@51 {
reg = <ADC5_AMUX_THM5_100K_PU>;
label = "charger_temp";
};
--
2.20.1
next prev parent reply other threads:[~2019-07-22 12:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 12:34 [PATCH 0/5] arm64: dts: qcom: sdm845: Fix DTS warnings Vinod Koul
2019-07-22 12:34 ` [PATCH 1/5] arm64: dts: qcom: sdm845: Add unit name to soc node Vinod Koul
2019-07-23 14:50 ` Stephen Boyd
2019-07-23 14:50 ` Stephen Boyd
2019-07-24 4:07 ` Vinod Koul
2019-07-22 12:34 ` [PATCH 2/5] arm64: dts: qcom: sdm845: remove unnecessary properties for dsi nodes Vinod Koul
2019-07-23 14:45 ` Stephen Boyd
2019-07-23 14:45 ` Stephen Boyd
2019-07-22 12:34 ` [PATCH 3/5] arm64: dts: qcom: sdm845: remove unit name for thermal trip points Vinod Koul
2019-07-23 14:47 ` Stephen Boyd
2019-07-23 14:47 ` Stephen Boyd
2019-07-22 12:34 ` [PATCH 4/5] arm64: dts: qcom: sdm845: remove macro from unit name Vinod Koul
2019-07-22 13:18 ` Marc Gonzalez
2019-07-22 13:48 ` Vinod Koul
2019-07-22 12:34 ` Vinod Koul [this message]
2019-07-23 5:08 ` [PATCH 5/5] arm64: dts: qcom: sdm845-cheza: " Amit Kucheria
2019-07-23 5:08 ` Amit Kucheria
2019-07-23 5:14 ` Vinod Koul
2019-07-23 5:14 ` Vinod Koul
2019-07-23 5:41 ` Bjorn Andersson
2019-07-23 5:41 ` Bjorn Andersson
2019-07-23 14:51 ` Stephen Boyd
2019-07-23 14:51 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190722123422.4571-6-vkoul@kernel.org \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.