From: Christian Brauner <christian@brauner.io>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org, oleg@redhat.com,
torvalds@linux-foundation.org, arnd@arndb.de,
ebiederm@xmission.com, joel@joelfernandes.org,
tglx@linutronix.de, tj@kernel.org, dhowells@redhat.com,
jannh@google.com, luto@kernel.org, akpm@linux-foundation.org,
cyphar@cyphar.com, viro@zeniv.linux.org.uk,
kernel-team@android.com
Subject: Re: [PATCH v3 2/2] pidfd: add pidfd_wait tests
Date: Mon, 29 Jul 2019 19:55:23 +0200 [thread overview]
Message-ID: <20190729175523.5mca4wnmoldu2olp@brauner.io> (raw)
In-Reply-To: <201907290929.09B5189@keescook>
On Mon, Jul 29, 2019 at 09:31:23AM -0700, Kees Cook wrote:
> On Sun, Jul 28, 2019 at 12:22:30AM +0200, Christian Brauner wrote:
> > Add tests for pidfd_wait() and CLONE_WAIT_PID:
> > - test that waitid(P_PIDFD) can wait on a pidfd
> > - test that waitid(P_PIDFD) can wait on a pidfd and return siginfo_t
> > - test that waitid(P_PIDFD) works with WEXITED
> > - test that waitid(P_PIDFD) works with WSTOPPED
> > - test that waitid(P_PIDFD) works with WUNTRACED
> > - test that waitid(P_PIDFD) works with WCONTINUED
> > - test that waitid(P_PIDFD) works with WNOWAIT
> > - test that waitid(P_PIDFD)works with WNOHANG
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
>
> This all looks good to me! :) One note that doesn't apply to this patch
> in particular, but might be nice to add (as I didn't see in the existing
> tests) was testing for pathological conditions: passing in /dev/zero for
> the pidfd, etc. (Maybe I missed those?)
Yeah, I can probably just add one for this scenario. :)
Thanks!
Christian
prev parent reply other threads:[~2019-07-29 17:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-27 22:22 [PATCH v3 0/2] pidfd: waiting on processes through pidfds Christian Brauner
2019-07-27 22:22 ` [PATCH v3 1/2] pidfd: add P_PIDFD to waitid() Christian Brauner
2019-07-29 14:27 ` Oleg Nesterov
2019-07-29 14:54 ` Christian Brauner
2019-07-29 16:24 ` Kees Cook
2019-07-29 17:56 ` Christian Brauner
2019-07-27 22:22 ` [PATCH v3 2/2] pidfd: add pidfd_wait tests Christian Brauner
2019-07-29 16:31 ` Kees Cook
2019-07-29 17:55 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190729175523.5mca4wnmoldu2olp@brauner.io \
--to=christian@brauner.io \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=cyphar@cyphar.com \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=jannh@google.com \
--cc=joel@joelfernandes.org \
--cc=keescook@chromium.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=oleg@redhat.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.