From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Denis Efremov <efremov@linux.com>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Emil Velikov <emil.l.velikov@gmail.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] modpost: check for static EXPORT_SYMBOL* functions
Date: Mon, 29 Jul 2019 22:20:45 +1000 [thread overview]
Message-ID: <20190729222045.4b491ffb@canb.auug.org.au> (raw)
In-Reply-To: <20190729092250.32670-1-efremov@linux.com>
[-- Attachment #1: Type: text/plain, Size: 288 bytes --]
Hi Denis,
Just a small note (nit? :-)):
On Mon, 29 Jul 2019 12:22:50 +0300 Denis Efremov <efremov@linux.com> wrote:
>
> + if (s->is_static)
> + warn("\"%s\" [%s] is the static %s\n",
This read a little wrong to me, maybe "is a static"?
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-07-29 12:20 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-14 15:28 [RFC PATCH] modpost: check for static EXPORT_SYMBOL* functions Denis Efremov
2019-07-15 14:43 ` Emil Velikov
2019-07-27 12:55 ` Masahiro Yamada
2019-07-27 19:13 ` Denis Efremov
2019-07-28 2:00 ` Masahiro Yamada
2019-07-28 10:09 ` [PATCH] " Denis Efremov
2019-07-29 3:29 ` Masahiro Yamada
2019-07-29 9:51 ` Denis Efremov
2019-07-29 5:13 ` Stephen Rothwell
2019-07-29 9:16 ` Denis Efremov
2019-07-29 9:32 ` Masahiro Yamada
2019-07-29 12:40 ` Stephen Rothwell
2019-07-29 12:52 ` Denis Efremov
2019-07-29 13:07 ` Stephen Rothwell
2019-07-29 9:22 ` [PATCH v2] " Denis Efremov
2019-07-29 12:20 ` Stephen Rothwell [this message]
2019-07-29 12:47 ` Denis Efremov
2019-07-29 14:18 ` [PATCH v3] " Denis Efremov
2019-07-29 22:26 ` Stephen Rothwell
2019-07-30 6:59 ` Denis Efremov
2019-07-30 16:29 ` Masahiro Yamada
2019-07-30 16:44 ` Denis Efremov
2019-07-30 17:21 ` Masahiro Yamada
2019-07-30 18:11 ` [PATCH v4] " Denis Efremov
2019-07-30 18:15 ` Denis Efremov
2019-07-31 8:54 ` Masahiro Yamada
2019-08-01 2:20 ` Masahiro Yamada
2019-08-01 6:17 ` Denis Efremov
2019-08-01 6:06 ` [PATCH v5] " Denis Efremov
2019-08-07 15:12 ` Masahiro Yamada
2019-08-13 16:07 ` Masahiro Yamada
2019-08-13 21:11 ` Denis Efremov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190729222045.4b491ffb@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=efremov@linux.com \
--cc=emil.l.velikov@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.