Re: [Qemu-devel] [Qemu-block] [PATCH v7 12/15] qemu-img: adds option to use aio engine for benchmarking

From: Stefan Hajnoczi <stefanha@gmail.com>
To: Aarushi Mehta <mehta.aaru20@gmail.com>
Cc: Fam Zheng <fam@euphon.net>, Kevin Wolf <kwolf@redhat.com>,
	Stefan Hajnoczi <stefan@redhat.com>,
	qemu-block@nongnu.org, qemu-devel@nongnu.org,
	Markus Armbruster <armbru@redhat.com>,
	saket.sinha89@gmail.com, Stefan Hajnoczi <stefanha@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Max Reitz <mreitz@redhat.com>, Julia Suvorova <jusual@mail.ru>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v7 12/15] qemu-img: adds option to use aio engine for benchmarking
Date: Tue, 30 Jul 2019 08:37:12 +0100	[thread overview]
Message-ID: <20190730073712.GD30213@stefanha-x1.localdomain> (raw)
In-Reply-To: <20190729151651.21306-13-mehta.aaru20@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1039 bytes --]

On Mon, Jul 29, 2019 at 08:46:48PM +0530, Aarushi Mehta wrote:
> Signed-off-by: Aarushi Mehta <mehta.aaru20@gmail.com>
> ---
>  qemu-img.c    | 10 +++++++++-
>  qemu-img.texi |  5 ++++-
>  2 files changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/qemu-img.c b/qemu-img.c
> index 79983772de..3fc8dac0b1 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -4192,7 +4192,8 @@ static int img_bench(int argc, char **argv)
>              {"force-share", no_argument, 0, 'U'},
>              {0, 0, 0, 0}
>          };
> -        c = getopt_long(argc, argv, ":hc:d:f:no:qs:S:t:wU", long_options, NULL);
> +        c = getopt_long(argc, argv, ":hc:d:f:ni:o:qs:S:t:wU", long_options,
> +                        NULL);

Please update help() with documentation for -i.

>          if (c == -1) {
>              break;
>          }
> @@ -4234,6 +4235,13 @@ static int img_bench(int argc, char **argv)
>              break;
>          case 'n':
>              flags |= BDRV_O_NATIVE_AIO;

Missing break statement.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]