From: Carlos Maiolino <cmaiolino@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-fsdevel@vger.kernel.org, hch@lst.de, adilger@dilger.ca,
jaegeuk@kernel.org, miklos@szeredi.hu, rpeterso@redhat.com,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 5/9] fs: Move start and length fiemap fields into fiemap_extent_info
Date: Mon, 5 Aug 2019 11:40:18 +0200 [thread overview]
Message-ID: <20190805094017.3tcskxxpssjolfmg@pegasus.maiolino.io> (raw)
In-Reply-To: <20190802151519.GH7138@magnolia>
On Fri, Aug 02, 2019 at 08:15:19AM -0700, Darrick J. Wong wrote:
> On Fri, Aug 02, 2019 at 11:51:16AM +0200, Carlos Maiolino wrote:
> > > >
> > > > STATIC int
> > > > xfs_vn_fiemap(
> > > > - struct inode *inode,
> > > > - struct fiemap_extent_info *fieinfo,
> > > > - u64 start,
> > > > - u64 length)
> > > > + struct inode *inode,
> > > > + struct fiemap_extent_info *fieinfo)
> > > > {
> > > > - int error;
> > > > + u64 start = fieinfo->fi_start;
> > > > + u64 length = fieinfo->fi_len;
> > > > + int error;
> > >
> > > Would be nice if the variable name indentation was consistent here, but
> > > otherwise the xfs part looks ok.
> >
> > These fields are removed on the next patch, updating it is really required?
>
> Yes, please.
NP then
> > > > + u64 fi_start;
> > > > + u64 fi_len;
> > >
> > > Comments for these two new fields?
> >
> > Sure, how about this:
> >
> > u64 fi_start; /* Logical offset at which
> > start mapping */
> > u64 fi_len; /* Logical length of mapping
> > the caller cares about */
> >
> >
> > btw, Above indentation won't match final result
>
> Looks good to me.
Will update the fields, thanks for the review
>
> >
> > Christoph, may I keep your reviewed tag by updating the comments as above?
> > Otherwise I'll just remove your tag
> >
> > >
> > > --D
> > >
> > > > + unsigned int fi_extents_mapped; /* Number of mapped extents */
> > > > + unsigned int fi_extents_max; /* Size of fiemap_extent array */
> > > > + struct fiemap_extent __user *fi_extents_start; /* Start of
> > > > + fiemap_extent
> > > > + array */
> > > > };
> > > > int fiemap_fill_next_extent(struct fiemap_extent_info *info, u64 logical,
> > > > u64 phys, u64 len, u32 flags);
> > > > @@ -1841,8 +1844,7 @@ struct inode_operations {
> > > > int (*setattr) (struct dentry *, struct iattr *);
> > > > int (*getattr) (const struct path *, struct kstat *, u32, unsigned int);
> > > > ssize_t (*listxattr) (struct dentry *, char *, size_t);
> > > > - int (*fiemap)(struct inode *, struct fiemap_extent_info *, u64 start,
> > > > - u64 len);
> > > > + int (*fiemap)(struct inode *, struct fiemap_extent_info *);
> > > > int (*update_time)(struct inode *, struct timespec64 *, int);
> > > > int (*atomic_open)(struct inode *, struct dentry *,
> > > > struct file *, unsigned open_flag,
> > > > @@ -3199,11 +3201,10 @@ extern int vfs_readlink(struct dentry *, char __user *, int);
> > > >
> > > > extern int __generic_block_fiemap(struct inode *inode,
> > > > struct fiemap_extent_info *fieinfo,
> > > > - loff_t start, loff_t len,
> > > > get_block_t *get_block);
> > > > extern int generic_block_fiemap(struct inode *inode,
> > > > - struct fiemap_extent_info *fieinfo, u64 start,
> > > > - u64 len, get_block_t *get_block);
> > > > + struct fiemap_extent_info *fieinfo,
> > > > + get_block_t *get_block);
> > > >
> > > > extern struct file_system_type *get_filesystem(struct file_system_type *fs);
> > > > extern void put_filesystem(struct file_system_type *fs);
> > > > --
> > > > 2.20.1
> > > >
> >
> > --
> > Carlos
--
Carlos
next prev parent reply other threads:[~2019-08-05 9:40 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 14:12 [PATCH 0/9 V4] New ->fiemap infrastructure and ->bmap removal Carlos Maiolino
2019-07-31 14:12 ` [PATCH 1/9] fs: Enable bmap() function to properly return errors Carlos Maiolino
2019-07-31 14:12 ` [PATCH 2/9] cachefiles: drop direct usage of ->bmap method Carlos Maiolino
2019-07-31 14:12 ` [PATCH 3/9] ecryptfs: drop direct calls to ->bmap Carlos Maiolino
2019-07-31 14:12 ` [PATCH 4/9] fibmap: Use bmap instead of ->bmap method in ioctl_fibmap Carlos Maiolino
2019-07-31 23:12 ` Darrick J. Wong
2019-08-02 9:19 ` Carlos Maiolino
2019-08-02 15:14 ` Darrick J. Wong
2019-08-05 10:27 ` Carlos Maiolino
2019-08-05 15:12 ` Darrick J. Wong
2019-08-06 5:38 ` Christoph Hellwig
2019-08-06 12:07 ` Carlos Maiolino
2019-08-06 14:48 ` Darrick J. Wong
2019-08-08 7:17 ` Carlos Maiolino
2019-08-06 12:02 ` Carlos Maiolino
2019-08-06 22:41 ` Luis Chamberlain
2019-08-07 14:42 ` Darrick J. Wong
2019-08-08 7:12 ` Carlos Maiolino
2019-08-08 18:53 ` Andreas Dilger
2019-08-19 10:10 ` Carlos Maiolino
2019-07-31 14:12 ` [PATCH 5/9] fs: Move start and length fiemap fields into fiemap_extent_info Carlos Maiolino
2019-07-31 23:28 ` Darrick J. Wong
2019-08-02 9:51 ` Carlos Maiolino
2019-08-02 15:15 ` Darrick J. Wong
2019-08-05 9:40 ` Carlos Maiolino [this message]
2019-08-06 5:39 ` Christoph Hellwig
2019-07-31 14:12 ` [PATCH 6/9] iomap: Remove length and start fields from iomap_fiemap Carlos Maiolino
2019-07-31 23:24 ` Darrick J. Wong
2019-07-31 14:12 ` [PATCH 7/9] fiemap: Use a callback to fill fiemap extents Carlos Maiolino
2019-07-31 23:26 ` Darrick J. Wong
2019-07-31 14:12 ` [PATCH 8/9] Use FIEMAP for FIBMAP calls Carlos Maiolino
2019-07-31 14:12 ` Carlos Maiolino
2019-07-31 23:22 ` Darrick J. Wong
2019-07-31 23:31 ` Darrick J. Wong
2019-08-02 13:52 ` Carlos Maiolino
2019-08-06 5:41 ` Christoph Hellwig
2019-08-02 13:48 ` Carlos Maiolino
2019-08-02 15:29 ` Darrick J. Wong
2019-08-05 10:38 ` Carlos Maiolino
2019-08-06 5:46 ` Christoph Hellwig
2019-07-31 14:12 ` [PATCH 9/9] xfs: Get rid of ->bmap Carlos Maiolino
2019-07-31 23:30 ` Darrick J. Wong
2019-08-02 10:20 ` [PATCH 0/9 V4] New ->fiemap infrastructure and ->bmap removal Carlos Maiolino
-- strict thread matches above, loose matches on Subject: below --
2019-09-11 13:43 [PATCH 0/9 V6] " Carlos Maiolino
2019-09-11 13:43 ` [PATCH 5/9] fs: Move start and length fiemap fields into fiemap_extent_info Carlos Maiolino
2019-09-16 17:42 ` Darrick J. Wong
2019-08-08 8:27 [PATCH 0/9 V5] New ->fiemap infrastructure and ->bmap removal Carlos Maiolino
2019-08-08 8:27 ` [PATCH 5/9] fs: Move start and length fiemap fields into fiemap_extent_info Carlos Maiolino
2019-08-08 20:21 ` kbuild test robot
2019-02-18 13:03 [PATCH 0/9 V3] New ->fiemap infrastructure and ->bmap removal Carlos Maiolino
2019-02-18 13:03 ` [PATCH 5/9] fs: Move start and length fiemap fields into fiemap_extent_info Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190805094017.3tcskxxpssjolfmg@pegasus.maiolino.io \
--to=cmaiolino@redhat.com \
--cc=adilger@dilger.ca \
--cc=darrick.wong@oracle.com \
--cc=hch@lst.de \
--cc=jaegeuk@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.