All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [GIT PULL] ASoC updates for v5.3
Date: Mon, 5 Aug 2019 19:04:18 +0100	[thread overview]
Message-ID: <20190805180418.GL6432@sirena.org.uk> (raw)
In-Reply-To: <s5hef1zpkke.wl-tiwai@suse.de>


[-- Attachment #1.1: Type: text/plain, Size: 823 bytes --]

On Mon, Aug 05, 2019 at 07:51:29PM +0200, Takashi Iwai wrote:
> Mark Brown wrote:

> > The support for new sample rates in the max98373 driver is a fix for the
> > fact that the driver declared support for those rates but would in fact
> > return an error if these rates were selected.

> Hm, the commit b9da500bde81 looks strange.

> The author and sign-off isn't with a proper name, and moreover, the
> patch modifies the file permissions.

Eh, the name looks perfectly fine for a Chinese name and matches the
e-mail address well enough - it's a slightly unusual transliteration but
if that's how ther want to do it I see no reason to complain, it's their
name.  File permissions are a mistake though, I can send an incremental
patch for that?  Kind of surprised none of the bots or people scanning
for stuff noticed it.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2019-08-05 18:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-05 13:13 [GIT PULL] ASoC updates for v5.3 Mark Brown
2019-08-05 17:51 ` Takashi Iwai
2019-08-05 18:04   ` Mark Brown [this message]
2019-08-05 18:48     ` Takashi Iwai
  -- strict thread matches above, loose matches on Subject: below --
2019-07-08 10:30 Mark Brown
2019-07-08 13:07 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190805180418.GL6432@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=lgirdwood@gmail.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.