From: Patchwork <patchwork@emeril.freedesktop.org>
To: Stuart Summers <stuart.summers@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for Refactor to expand subslice mask (rev 2)
Date: Wed, 07 Aug 2019 18:14:06 -0000 [thread overview]
Message-ID: <20190807181406.24672.83048@emeril.freedesktop.org> (raw)
In-Reply-To: <20190807165832.26324-1-stuart.summers@intel.com>
== Series Details ==
Series: Refactor to expand subslice mask (rev 2)
URL : https://patchwork.freedesktop.org/series/64858/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
98fa1b8ef9ca drm/i915: Use variable for debugfs device status
73dd1f518679 drm/i915: Add function to set SSEU info per platform
617a23ac375f drm/i915: Add subslice stride runtime parameter
73a23ff180b7 drm/i915: Add EU stride runtime parameter
07e06271d0c6 drm/i915: Add function to set subslices
4f88b7577d6e drm/i915: Add function to determine if a slice has a subslice
f03d0837a0de drm/i915: Refactor instdone loops on new subslice functions
-:60: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'subslice__' - possible side-effects?
#60: FILE: drivers/gpu/drm/i915/gt/intel_engine_types.h:551:
+#define instdone_has_subslice(dev_priv__, sseu__, slice__, subslice__) \
+ (IS_GEN(dev_priv__, 7) ? (1 & BIT(subslice__)) : \
+ intel_sseu_has_subslice(sseu__, 0, subslice__))
-:64: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv_' - possible side-effects?
#64: FILE: drivers/gpu/drm/i915/gt/intel_engine_types.h:555:
+#define for_each_instdone_slice_subslice(dev_priv_, sseu_, slice_, subslice_) \
+ for ((slice_) = 0, (subslice_) = 0; (slice_) < I915_MAX_SLICES; \
+ (subslice_) = ((subslice_) + 1) % I915_MAX_SUBSLICES, \
+ (slice_) += ((subslice_) == 0)) \
+ for_each_if((instdone_has_slice(dev_priv_, sseu_, slice_)) && \
+ (instdone_has_subslice(dev_priv_, sseu_, slice_, \
+ subslice_)))
-:64: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'sseu_' - possible side-effects?
#64: FILE: drivers/gpu/drm/i915/gt/intel_engine_types.h:555:
+#define for_each_instdone_slice_subslice(dev_priv_, sseu_, slice_, subslice_) \
+ for ((slice_) = 0, (subslice_) = 0; (slice_) < I915_MAX_SLICES; \
+ (subslice_) = ((subslice_) + 1) % I915_MAX_SUBSLICES, \
+ (slice_) += ((subslice_) == 0)) \
+ for_each_if((instdone_has_slice(dev_priv_, sseu_, slice_)) && \
+ (instdone_has_subslice(dev_priv_, sseu_, slice_, \
+ subslice_)))
-:64: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'slice_' - possible side-effects?
#64: FILE: drivers/gpu/drm/i915/gt/intel_engine_types.h:555:
+#define for_each_instdone_slice_subslice(dev_priv_, sseu_, slice_, subslice_) \
+ for ((slice_) = 0, (subslice_) = 0; (slice_) < I915_MAX_SLICES; \
+ (subslice_) = ((subslice_) + 1) % I915_MAX_SUBSLICES, \
+ (slice_) += ((subslice_) == 0)) \
+ for_each_if((instdone_has_slice(dev_priv_, sseu_, slice_)) && \
+ (instdone_has_subslice(dev_priv_, sseu_, slice_, \
+ subslice_)))
-:64: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'subslice_' - possible side-effects?
#64: FILE: drivers/gpu/drm/i915/gt/intel_engine_types.h:555:
+#define for_each_instdone_slice_subslice(dev_priv_, sseu_, slice_, subslice_) \
+ for ((slice_) = 0, (subslice_) = 0; (slice_) < I915_MAX_SLICES; \
+ (subslice_) = ((subslice_) + 1) % I915_MAX_SUBSLICES, \
+ (slice_) += ((subslice_) == 0)) \
+ for_each_if((instdone_has_slice(dev_priv_, sseu_, slice_)) && \
+ (instdone_has_subslice(dev_priv_, sseu_, slice_, \
+ subslice_)))
total: 0 errors, 0 warnings, 5 checks, 106 lines checked
62bc8cbde24b drm/i915: Add new function to copy subslices for a slice
f0790c8c27fc drm/i915: Expand subslice mask
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-08-07 18:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 16:58 [PATCH 0/9] Refactor to expand subslice mask (rev 2) Stuart Summers
2019-08-07 16:58 ` [PATCH 1/9] drm/i915: Use variable for debugfs device status Stuart Summers
2019-08-07 16:58 ` [PATCH 2/9] drm/i915: Add function to set SSEU info per platform Stuart Summers
2019-08-07 16:58 ` [PATCH 3/9] drm/i915: Add subslice stride runtime parameter Stuart Summers
2019-08-07 16:58 ` [PATCH 4/9] drm/i915: Add EU " Stuart Summers
2019-08-07 16:58 ` [PATCH 5/9] drm/i915: Add function to set subslices Stuart Summers
2019-08-07 16:58 ` [PATCH 6/9] drm/i915: Add function to determine if a slice has a subslice Stuart Summers
2019-08-07 22:09 ` Chris Wilson
2019-08-07 16:58 ` [PATCH 7/9] drm/i915: Refactor instdone loops on new subslice functions Stuart Summers
2019-08-07 16:58 ` [PATCH 8/9] drm/i915: Add new function to copy subslices for a slice Stuart Summers
2019-08-07 16:58 ` [PATCH 9/9] drm/i915: Expand subslice mask Stuart Summers
2019-08-07 18:14 ` Patchwork [this message]
2019-08-07 19:09 ` ✓ Fi.CI.BAT: success for Refactor to expand subslice mask (rev 2) Patchwork
2019-08-08 5:59 ` ✗ Fi.CI.IGT: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2019-08-23 16:02 [PATCH 00/11] " Stuart Summers
2019-08-23 17:41 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-08-22 18:32 [PATCH 00/11] " Stuart Summers
2019-08-22 18:45 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-08-20 23:05 [PATCH 00/11] " Stuart Summers
2019-08-20 23:59 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-08-19 21:49 [PATCH 0/9] " Stuart Summers
2019-08-19 21:55 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-08-19 21:18 [PATCH 0/9] " Stuart Summers
2019-08-19 21:29 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-08-02 20:51 [PATCH 00/10] " Stuart Summers
2019-08-02 21:00 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-07-24 17:12 [PATCH 0/9] " Stuart Summers
2019-07-24 17:28 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-07-23 15:49 [PATCH 0/9] " Stuart Summers
2019-07-23 17:42 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190807181406.24672.83048@emeril.freedesktop.org \
--to=patchwork@emeril.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stuart.summers@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.