Re: [PATCH v2 1/4] dt-bindings: soundwire: add slave bindings

From: Mark Brown <broonie@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	vkoul@kernel.org, bgoswami@codeaurora.org, plai@codeaurora.org,
	robh+dt@kernel.org, devicetree@vger.kernel.org,
	lgirdwood@gmail.com, alsa-devel@alsa-project.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: soundwire: add slave bindings
Date: Thu, 8 Aug 2019 20:52:16 +0100	[thread overview]
Message-ID: <20190808195216.GM3795@sirena.co.uk> (raw)
In-Reply-To: <cdd2bded-551c-65f5-ca29-d2bb825bdaba@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 862 bytes --]

On Thu, Aug 08, 2019 at 05:48:56PM +0100, Srinivas Kandagatla wrote:
> On 08/08/2019 16:58, Pierre-Louis Bossart wrote:

> > > +- sdw-instance-id: Should be ('Instance ID') from SoundWire
> > > +          Enumeration Address. Instance ID is for the cases
> > > +          where multiple Devices of the same type or Class
> > > +          are attached to the bus.

> > so it is actually required if you have a single Slave device? Or is it
> > only required when you have more than 1 device of the same type?

> This is mandatory for any slave device!

If it's mandatory the wording is a bit unclear.  How about something
like:

	Should be ('Instance ID') from the SoundWire Enumeration
	Address.  This must always be provided, if multiple devices
	with the same type or class or attached to the bus each
	instance must have a distinct value.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]