From: P J P <ppandit@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Fam Zheng <fam@euphon.net>,
Prasad J Pandit <pjp@fedoraproject.org>,
Marcelo Tosatti <mtosatti@redhat.com>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
QEMU Developers <qemu-devel@nongnu.org>,
Bugs SysSec <bugs-syssec@rub.de>,
Paolo Bonzini <pbonzini@redhat.com>,
Stefano Garzarella <sgarzare@redhat.com>
Subject: [Qemu-devel] [PATCH v3 2/2] scsi: lsi: use macro LSI_MAX_INSN instead of a magic number
Date: Fri, 9 Aug 2019 12:08:35 +0530 [thread overview]
Message-ID: <20190809063835.6717-3-ppandit@redhat.com> (raw)
In-Reply-To: <20190809063835.6717-1-ppandit@redhat.com>
From: Prasad J Pandit <pjp@fedoraproject.org>
Use macro 'LSI_MAX_INSN' instead of a magic number 10000.
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
---
hw/scsi/lsi53c895a.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c
index e703ef4c9d..f6786607f8 100644
--- a/hw/scsi/lsi53c895a.c
+++ b/hw/scsi/lsi53c895a.c
@@ -1578,7 +1578,7 @@ again:
}
}
}
- if (insn_processed > 10000 && s->waiting == LSI_NOWAIT) {
+ if (insn_processed > LSI_MAX_INSN && s->waiting == LSI_NOWAIT) {
/* Some windows drivers make the device spin waiting for a memory
location to change. If we have been executed a lot of code then
assume this is the case and force an unexpected device disconnect.
--
2.21.0
prev parent reply other threads:[~2019-08-09 6:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 6:38 [Qemu-devel] [PATCH v3 0/2] scsi: lsi: break infinite loop after 10k instructions P J P
2019-08-09 6:38 ` [Qemu-devel] [PATCH v3 1/2] scsi: lsi: exit infinite loop while executing script (CVE-2019-12068) P J P
2019-08-13 10:05 ` P J P
2019-08-13 10:31 ` Philippe Mathieu-Daudé
2019-08-13 14:33 ` Paolo Bonzini
2019-08-14 10:25 ` P J P
2019-08-14 10:38 ` Paolo Bonzini
2019-08-14 12:08 ` P J P
2019-08-09 6:38 ` P J P [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190809063835.6717-3-ppandit@redhat.com \
--to=ppandit@redhat.com \
--cc=bugs-syssec@rub.de \
--cc=fam@euphon.net \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=pjp@fedoraproject.org \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.