Re: [PATCH 2/2] btrfs: compression: replace set_level callbacks by a common helper

From: kbuild test robot <lkp@intel.com>
To: David Sterba <dsterba@suse.com>
Cc: kbuild-all@01.org, linux-btrfs@vger.kernel.org,
	David Sterba <dsterba@suse.com>
Subject: Re: [PATCH 2/2] btrfs: compression: replace set_level callbacks by a common helper
Date: Sun, 11 Aug 2019 21:08:46 +0800	[thread overview]
Message-ID: <201908112106.gXw89yn4%lkp@intel.com> (raw)
In-Reply-To: <e23e0b52dce1fe0ee2c78a0f54ea7d722d0d34c3.1565362438.git.dsterba@suse.com>

[-- Attachment #1: Type: text/plain, Size: 3027 bytes --]

Hi David,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.3-rc3 next-20190809]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/David-Sterba/Compression-level-API-cleanups/20190811-193645
config: x86_64-randconfig-h002-201932 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-10) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   ld: fs/btrfs/compression.o: in function `btrfs_compress_pages':
>> fs/btrfs/compression.c:1042: undefined reference to `btrfs_compress_set_level'
   ld: fs/btrfs/compression.o: in function `btrfs_compress_str2level':
   fs/btrfs/compression.c:1614: undefined reference to `btrfs_compress_set_level'

vim +1042 fs/btrfs/compression.c

  1007	
  1008	/*
  1009	 * Given an address space and start and length, compress the bytes into @pages
  1010	 * that are allocated on demand.
  1011	 *
  1012	 * @type_level is encoded algorithm and level, where level 0 means whatever
  1013	 * default the algorithm chooses and is opaque here;
  1014	 * - compression algo are 0-3
  1015	 * - the level are bits 4-7
  1016	 *
  1017	 * @out_pages is an in/out parameter, holds maximum number of pages to allocate
  1018	 * and returns number of actually allocated pages
  1019	 *
  1020	 * @total_in is used to return the number of bytes actually read.  It
  1021	 * may be smaller than the input length if we had to exit early because we
  1022	 * ran out of room in the pages array or because we cross the
  1023	 * max_out threshold.
  1024	 *
  1025	 * @total_out is an in/out parameter, must be set to the input length and will
  1026	 * be also used to return the total number of compressed bytes
  1027	 *
  1028	 * @max_out tells us the max number of bytes that we're allowed to
  1029	 * stuff into pages
  1030	 */
  1031	int btrfs_compress_pages(unsigned int type_level, struct address_space *mapping,
  1032				 u64 start, struct page **pages,
  1033				 unsigned long *out_pages,
  1034				 unsigned long *total_in,
  1035				 unsigned long *total_out)
  1036	{
  1037		int type = btrfs_compress_type(type_level);
  1038		int level = btrfs_compress_level(type_level);
  1039		struct list_head *workspace;
  1040		int ret;
  1041	
> 1042		level = btrfs_compress_set_level(type, level);
  1043		workspace = get_workspace(type, level);
  1044		ret = btrfs_compress_op[type]->compress_pages(workspace, mapping,
  1045							      start, pages,
  1046							      out_pages,
  1047							      total_in, total_out);
  1048		put_workspace(type, workspace);
  1049		return ret;
  1050	}
  1051	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30830 bytes --]