Re: cleanup the walk_page_range interface

From: Mike Rapoport <rppt@linux.ibm.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "Linus Torvalds" <torvalds@linux-foundation.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Thomas Hellström" <thomas@shipmail.org>,
	"Jerome Glisse" <jglisse@redhat.com>,
	"Jason Gunthorpe" <jgg@mellanox.com>,
	"Steven Price" <steven.price@arm.com>,
	Linux-MM <linux-mm@kvack.org>,
	"Linux List Kernel Mailing" <linux-kernel@vger.kernel.org>
Subject: Re: cleanup the walk_page_range interface
Date: Mon, 12 Aug 2019 09:17:56 +0300	[thread overview]
Message-ID: <20190812061756.GA28471@rapoport-lnx> (raw)
In-Reply-To: <20190808215632.GA12773@lst.de>

On Thu, Aug 08, 2019 at 11:56:32PM +0200, Christoph Hellwig wrote:
> On Thu, Aug 08, 2019 at 10:50:37AM -0700, Linus Torvalds wrote:
> > > Note that both Thomas and Steven have series touching this area pending,
> > > and there are a couple consumer in flux too - the hmm tree already
> > > conflicts with this series, and I have potential dma changes on top of
> > > the consumers in Thomas and Steven's series, so we'll probably need a
> > > git tree similar to the hmm one to synchronize these updates.
> > 
> > I'd be willing to just merge this now, if that helps. The conversion
> > is mechanical, and my only slight worry would be that at least for my
> > original patch I didn't build-test the (few) non-x86
> > architecture-specific cases. But I did end up looking at them fairly
> > closely  (basically using some grep/sed scripts to see that the
> > conversions I did matched the same patterns). And your changes look
> > like obvious improvements too where any mistake would have been caught
> > by the compiler.
> 
> I did cross compile the s390 and powerpc bits, but I do not have an
> openrisc compiler.

The openrisc defconfig builds fine.

> > So I'm not all that worried from a functionality standpoint, and if
> > this will help the next merge window, I'll happily pull now.
> 
> That would help with this series vs the others, but not with the other
> series vs each other.
> 

-- 
Sincerely yours,
Mike.