Re: [PATCH v2 1/1] waitid: Add support for waiting for the current process group

From: Oleg Nesterov <oleg@redhat.com>
To: Christian Brauner <christian.brauner@ubuntu.com>
Cc: linux-kernel@vger.kernel.org, libc-alpha@sourceware.org,
	alistair23@gmail.com, ebiederm@xmission.com, arnd@arndb.de,
	dalias@libc.org, torvalds@linux-foundation.org,
	adhemerval.zanella@linaro.org, fweimer@redhat.com,
	palmer@sifive.com, macro@wdc.com, zongbox@gmail.com,
	akpm@linux-foundation.org, viro@zeniv.linux.org.uk,
	hpa@zytor.com
Subject: Re: [PATCH v2 1/1] waitid: Add support for waiting for the current process group
Date: Wed, 14 Aug 2019 16:19:57 +0200	[thread overview]
Message-ID: <20190814141956.GC11595@redhat.com> (raw)
In-Reply-To: <20190814130732.23572-2-christian.brauner@ubuntu.com>

On 08/14, Christian Brauner wrote:
>
> +static struct pid *find_get_pgrp(pid_t nr)
> +{
> +	struct pid *pid;
> +
> +	if (nr)
> +		return find_get_pid(nr);
> +
> +	rcu_read_lock();
> +	pid = get_pid(task_pgrp(current));
> +	rcu_read_unlock();
> +
> +	return pid;
> +}

I can't say I like this helper... even its name doesn't look good to me.

I forgot that we already have get_task_pid() when I replied to the previous
version... How about

	case P_PGID:

		if (upid)
			pid = find_get_pid(upid);
		else
			pid = get_task_pid(current, PIDTYPE_PGID);

?

Oleg.