✗ Fi.CI.CHECKPATCH: warning for hmm & mmu_notifier debug/lockdep annotations

From: Patchwork <patchwork@emeril.freedesktop.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for hmm & mmu_notifier debug/lockdep annotations
Date: Wed, 14 Aug 2019 21:29:20 -0000	[thread overview]
Message-ID: <20190814212920.21410.77693@emeril.freedesktop.org> (raw)
In-Reply-To: <20190814202027.18735-1-daniel.vetter@ffwll.ch>

== Series Details ==

Series: hmm & mmu_notifier debug/lockdep annotations
URL   : https://patchwork.freedesktop.org/series/65204/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
5a4f96d9f7a6 mm: Check if mmu notifier callbacks are allowed to fail
-:64: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
39d0c9af3003 kernel.h: Add non_block_start/end()
-:78: WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#78: FILE: include/linux/kernel.h:238:
+# define non_block_start() \
+	do { current->non_block_count++; } while (0)

-:80: WARNING:SINGLE_STATEMENT_DO_WHILE_MACRO: Single statement macros should not use a do {} while (0) loop
#80: FILE: include/linux/kernel.h:240:
+# define non_block_end() \
+	do { WARN_ON(current->non_block_count-- == 0); } while (0)

-:127: WARNING:PREFER_PR_LEVEL: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...
#127: FILE: kernel/sched/core.c:3712:
+		printk(KERN_ERR "BUG: scheduling in a non-blocking section: %s/%d/%i\n",

-:128: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#128: FILE: kernel/sched/core.c:3713:
+		printk(KERN_ERR "BUG: scheduling in a non-blocking section: %s/%d/%i\n",
+			prev->comm, prev->pid, prev->non_block_count);

-:165: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'

total: 0 errors, 4 warnings, 1 checks, 87 lines checked
dc71123d4109 mm, notifier: Catch sleeping/blocking for !blockable
-:57: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 14 lines checked
e45141adafb7 mm, notifier: Add a lockdep map for invalidate_range_start
-:94: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 35 lines checked
f19fc63b377a mm/hmm: WARN on illegal ->sync_cpu_device_pagetables errors
-:41: WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Daniel Vetter <daniel.vetter@ffwll.ch>'

total: 0 errors, 1 warnings, 0 checks, 9 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx