From: Eric Biggers <ebiggers@kernel.org>
To: linux-fscrypt@vger.kernel.org
Subject: Re: [PATCH] fscrypt: clean up base64 encoding/decoding
Date: Wed, 14 Aug 2019 15:30:11 -0700 [thread overview]
Message-ID: <20190814223011.GC101319@gmail.com> (raw)
In-Reply-To: <20190724194606.40483-1-ebiggers@kernel.org>
On Wed, Jul 24, 2019 at 12:46:06PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Some minor cleanups for the code that base64 encodes and decodes
> encrypted filenames and long name digests:
>
> - Rename "digest_{encode,decode}()" => "base64_{encode,decode}()" since
> they are used for filenames too, not just for long name digests.
> - Replace 'while' loops with more conventional 'for' loops.
> - Use 'u8' for binary data. Keep 'char' for string data.
> - Fully constify the lookup table (pointer was not const).
> - Improve comment.
>
> No actual change in behavior.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Applied to fscrypt tree for 5.4.
- Eric
prev parent reply other threads:[~2019-08-14 22:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 19:46 [PATCH] fscrypt: clean up base64 encoding/decoding Eric Biggers
2019-08-14 22:30 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190814223011.GC101319@gmail.com \
--to=ebiggers@kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.