Re: [PATCH 4/6] ARM: dts: Configure sgx for omap5

From: Tony Lindgren <tony@atomide.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: linux-omap@vger.kernel.org,
	"Benoît Cousson" <bcousson@baylibre.com>,
	devicetree@vger.kernel.org, "Adam Ford" <aford173@gmail.com>,
	"Filip Matijević" <filip.matijevic.pz@gmail.com>,
	"H. Nikolaus Schaller" <hns@goldelico.com>,
	"Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
	"moaz korena" <moaz@korena.xyz>,
	"Merlijn Wajer" <merlijn@wizzup.org>,
	"Paweł Chmiel" <pawel.mikolaj.chmiel@gmail.com>,
	"Philipp Rossak" <embed3d@gmail.com>,
	"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Tero Kristo" <t-kristo@ti.com>,
	linux-clk@vger.kernel.org
Subject: Re: [PATCH 4/6] ARM: dts: Configure sgx for omap5
Date: Fri, 16 Aug 2019 23:56:15 -0700	[thread overview]
Message-ID: <20190817065615.GI52127@atomide.com> (raw)
In-Reply-To: <20190815182348.8A1BA2063F@mail.kernel.org>

* Stephen Boyd <sboyd@kernel.org> [190815 18:24]:
> Quoting Tony Lindgren (2019-08-14 06:14:06)
> > diff --git a/arch/arm/boot/dts/omap54xx-clocks.dtsi b/arch/arm/boot/dts/omap54xx-clocks.dtsi
> > --- a/arch/arm/boot/dts/omap54xx-clocks.dtsi
> > +++ b/arch/arm/boot/dts/omap54xx-clocks.dtsi
> > @@ -1146,6 +1146,20 @@
> >                 };
> >         };
> >  
> > +       gpu_cm: gpu_cm@1500 {
> 
> Node names shouldn't have underscores. Maybe clock-controller?

OK yeah clock-controller sounds good to me.

Thanks,

Tony