From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: linux-kernel@vger.kernel.org, tiwai@suse.de, broonie@kernel.org,
vkoul@kernel.org, gregkh@linuxfoundation.org, jank@cadence.com,
srinivas.kandagatla@linaro.org, slawomir.blauciak@intel.com,
Bard liao <yung-chuan.liao@linux.intel.com>,
Rander Wang <rander.wang@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: [PATCH v3 0/4] soundwire: debugfs support for 5.4
Date: Wed, 21 Aug 2019 13:58:17 -0500 [thread overview]
Message-ID: <20190821185821.12690-1-pierre-louis.bossart@linux.intel.com> (raw)
This patchset enables debugfs support and corrects all the feedback
provided on an earlier RFC ('soundwire: updates for 5.4')
There is one remaining hard-coded value in intel.c that will need to
be fixed in a follow-up patchset not specific to debugfs: we need to
remove hard-coded Intel-specific configurations from cadence_master.c
(PDI offsets, etc).
Changes since v2:
No code change, just rebase to soundwire/next
Added GKH and Sanyog's tags
Also added patch4 submitted earlier in another series which depends on
debugfs
Changes since v1 (Feedback from GKH)
Handle debugfs in a more self-contained way (no dentry as return or parameter)
Used CONFIG_DEBUG_FS in structures and code to make it easier to
remove if need be.
No functional change for register dumps.
Changes since RFC (Feedback from GKH, Vinod, Guennadi, Cezary, Sanyog):
removed error checks
used DEFINE_SHOW_ATTRIBUTE and seq_file
fixed copyright dates
fixed SPDX license info to use GPL2.0 only
fixed Makefile to include debugfs only if CONFIG_DEBUG_FS is selected
used static inlines for fallback compilation
removed intermediate variables
removed hard-coded constants in loops (used registers offsets and
hardware capabilities)
squashed patch 3
Pierre-Louis Bossart (4):
soundwire: add debugfs support
soundwire: cadence_master: add debugfs register dump
soundwire: intel: add debugfs register dump
soundwire: intel: handle disabled links
drivers/soundwire/Makefile | 4 +
drivers/soundwire/bus.c | 6 ++
drivers/soundwire/bus.h | 16 +++
drivers/soundwire/bus_type.c | 3 +
drivers/soundwire/cadence_master.c | 107 ++++++++++++++++++++
drivers/soundwire/cadence_master.h | 4 +
drivers/soundwire/debugfs.c | 151 +++++++++++++++++++++++++++++
drivers/soundwire/intel.c | 145 ++++++++++++++++++++++++++-
drivers/soundwire/slave.c | 1 +
include/linux/soundwire/sdw.h | 10 ++
10 files changed, 444 insertions(+), 3 deletions(-)
create mode 100644 drivers/soundwire/debugfs.c
base-commit: 183c7687802e4132eb782808a8bf80689a9219c1
--
2.20.1
next reply other threads:[~2019-08-21 18:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 18:58 Pierre-Louis Bossart [this message]
2019-08-21 18:58 ` [PATCH v3 1/4] soundwire: add debugfs support Pierre-Louis Bossart
2019-08-21 18:58 ` [PATCH v3 2/4] soundwire: cadence_master: add debugfs register dump Pierre-Louis Bossart
2019-08-21 18:58 ` [PATCH v3 3/4] soundwire: intel: " Pierre-Louis Bossart
2019-08-21 18:58 ` [PATCH v3 4/4] soundwire: intel: handle disabled links Pierre-Louis Bossart
2019-08-23 6:34 ` [PATCH v3 0/4] soundwire: debugfs support for 5.4 Vinod Koul
2019-08-23 15:34 ` [alsa-devel] " Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190821185821.12690-1-pierre-louis.bossart@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jank@cadence.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rander.wang@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=slawomir.blauciak@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.