✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: Support for DP HDR outputs

From: Patchwork <patchwork@emeril.freedesktop.org>
To: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: Support for DP HDR outputs
Date: Fri, 23 Aug 2019 02:15:39 -0000	[thread overview]
Message-ID: <20190823021539.14424.45219@emeril.freedesktop.org> (raw)
In-Reply-To: <20190823013501.14256-1-gwan-gyeong.mun@intel.com>

== Series Details ==

Series: drm/i915/dp: Support for DP HDR outputs
URL   : https://patchwork.freedesktop.org/series/65656/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
f56779e2a694 drm/i915/dp: Extend program of VSC Header and DB for Colorimetry Format
b8e7c747d444 drm/i915/dp: Add support of BT.2020 Colorimetry to DP MSA
-:35: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'crtc_state->output_format == INTEL_OUTPUT_FORMAT_YCBCR420'
#35: FILE: drivers/gpu/drm/i915/display/intel_ddi.c:1743:
+	if ((crtc_state->output_format == INTEL_OUTPUT_FORMAT_YCBCR420) ||
+	    (intel_dp_needs_vsc_colorimetry(crtc_state->output_colorspace)))

-:101: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'crtc_state->output_format != INTEL_OUTPUT_FORMAT_YCBCR420'
#101: FILE: drivers/gpu/drm/i915/display/intel_dp.c:4565:
+	if ((crtc_state->output_format != INTEL_OUTPUT_FORMAT_YCBCR420) &&
+	    (!intel_dp_needs_vsc_colorimetry(conn_state->colorspace)))

total: 0 errors, 0 warnings, 2 checks, 75 lines checked
1331f2e1059a drm: Add DisplayPort colorspace property
a7ceb6728f11 drm/i915/dp: Attach colorspace property
56f276fa0ec6 drm/i915/dp: Program an Infoframe SDP Header and DB for HDR Static Metadata
-:16: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#16: 
HDR Metadata Infoframe SDP packet, it adds and uses different register size.

-:59: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#59: FILE: drivers/gpu/drm/i915/display/intel_dp.c:4560:
 }
+static int

total: 0 errors, 1 warnings, 1 checks, 125 lines checked
26e1c6408097 drm/i915/dp: Attach HDR metadata property to DP connector
-:22: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#22: FILE: drivers/gpu/drm/i915/display/intel_dp.c:6505:
+		drm_object_attach_property(&connector->base,
+			connector->dev->mode_config.hdr_output_metadata_property, 0);

total: 0 errors, 0 warnings, 1 checks, 10 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx