Re: [PATCH v2 1/5] fs: Introduce i_blocks_per_page

From: kbuild test robot <lkp@intel.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: kbuild-all@01.org, linux-fsdevel@vger.kernel.org,
	"Matthew Wilcox (Oracle)" <willy@infradead.org>,
	hch@lst.de, linux-xfs@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2 1/5] fs: Introduce i_blocks_per_page
Date: Fri, 23 Aug 2019 20:26:31 +0800	[thread overview]
Message-ID: <201908232012.fltDEHQU%lkp@intel.com> (raw)
In-Reply-To: <20190821003039.12555-2-willy@infradead.org>

[-- Attachment #1: Type: text/plain, Size: 5975 bytes --]

Hi Matthew,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.3-rc5 next-20190823]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Matthew-Wilcox/iomap-xfs-support-for-large-pages/20190823-191138
config: c6x-allyesconfig (attached as .config)
compiler: c6x-elf-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=c6x 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/blkdev.h:16:0,
                    from include/linux/blk-cgroup.h:21,
                    from include/linux/writeback.h:14,
                    from include/linux/memcontrol.h:22,
                    from include/net/sock.h:53,
                    from net//tipc/socket.h:38,
                    from net//tipc/core.c:44:
   include/linux/pagemap.h: In function 'i_blocks_per_page':
>> include/linux/pagemap.h:640:9: error: implicit declaration of function 'page_size'; did you mean 'msg_size'? [-Werror=implicit-function-declaration]
     return page_size(page) >> inode->i_blkbits;
            ^~~~~~~~~
            msg_size
   cc1: some warnings being treated as errors
--
   In file included from include/linux/blkdev.h:16:0,
                    from include/linux/blk-cgroup.h:21,
                    from include/linux/writeback.h:14,
                    from include/linux/memcontrol.h:22,
                    from include/net/sock.h:53,
                    from net//tipc/socket.h:38,
                    from net//tipc/trace.h:45,
                    from net//tipc/trace.c:37:
   include/linux/pagemap.h: In function 'i_blocks_per_page':
>> include/linux/pagemap.h:640:9: error: implicit declaration of function 'page_size'; did you mean 'msg_size'? [-Werror=implicit-function-declaration]
     return page_size(page) >> inode->i_blkbits;
            ^~~~~~~~~
            msg_size
   In file included from net//tipc/trace.h:431:0,
                    from net//tipc/trace.c:37:
   include/trace/define_trace.h: At top level:
   include/trace/define_trace.h:95:42: fatal error: ./trace.h: No such file or directory
    #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
                                             ^
   cc1: some warnings being treated as errors
   compilation terminated.
--
   In file included from include/linux/blkdev.h:16:0,
                    from include/linux/blk-cgroup.h:21,
                    from include/linux/writeback.h:14,
                    from include/linux/memcontrol.h:22,
                    from include/net/sock.h:53,
                    from include/linux/tcp.h:19,
                    from include/linux/ipv6.h:87,
                    from include/net/ipv6.h:12,
                    from include/rdma/ib_verbs.h:51,
                    from include/linux/lsm_audit.h:25,
                    from security//apparmor/include/audit.h:16,
                    from security//apparmor/include/policy.h:23,
                    from security//apparmor/include/policy_ns.h:19,
                    from security//apparmor/include/cred.h:19,
                    from security//apparmor/task.c:15:
   include/linux/pagemap.h: In function 'i_blocks_per_page':
>> include/linux/pagemap.h:640:9: error: implicit declaration of function 'page_size'; did you mean 'table_size'? [-Werror=implicit-function-declaration]
     return page_size(page) >> inode->i_blkbits;
            ^~~~~~~~~
            table_size
   cc1: some warnings being treated as errors
--
   In file included from include/linux/blkdev.h:16:0,
                    from include/linux/blk-cgroup.h:21,
                    from include/linux/writeback.h:14,
                    from include/linux/memcontrol.h:22,
                    from include/net/sock.h:53,
                    from include/linux/tcp.h:19,
                    from include/linux/ipv6.h:87,
                    from include/net/ipv6.h:12,
                    from include/rdma/ib_verbs.h:51,
                    from include/linux/lsm_audit.h:25,
                    from security//apparmor/include/audit.h:16,
                    from security//apparmor/include/policy.h:23,
                    from security//apparmor/include/policy_ns.h:19,
                    from security//apparmor/include/cred.h:19,
                    from security//apparmor/capability.c:18:
   include/linux/pagemap.h: In function 'i_blocks_per_page':
>> include/linux/pagemap.h:640:9: error: implicit declaration of function 'page_size'; did you mean 'table_size'? [-Werror=implicit-function-declaration]
     return page_size(page) >> inode->i_blkbits;
            ^~~~~~~~~
            table_size
   security//apparmor/capability.c: At top level:
   security//apparmor/capability.c:25:10: fatal error: capability_names.h: No such file or directory
    #include "capability_names.h"
             ^~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors
   compilation terminated.

vim +640 include/linux/pagemap.h

   628	
   629	/**
   630	 * i_blocks_per_page - How many blocks fit in this page.
   631	 * @inode: The inode which contains the blocks.
   632	 * @page: The (potentially large) page.
   633	 *
   634	 * Context: Any context.
   635	 * Return: The number of filesystem blocks covered by this page.
   636	 */
   637	static inline
   638	unsigned int i_blocks_per_page(struct inode *inode, struct page *page)
   639	{
 > 640		return page_size(page) >> inode->i_blkbits;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 49703 bytes --]