From: Greg KH <gregkh@linuxfoundation.org>
To: "Schmid, Carsten" <Carsten_Schmid@mentor.com>
Cc: Mathias Nyman <mathias.nyman@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [Patch v5] usb: hcd: use managed device resources
Date: Sun, 25 Aug 2019 10:29:49 +0200 [thread overview]
Message-ID: <20190825082949.GA4583@kroah.com> (raw)
In-Reply-To: <1566569488679.31808@mentor.com>
On Fri, Aug 23, 2019 at 02:11:28PM +0000, Schmid, Carsten wrote:
> Using managed device resources in usb_hcd_pci_probe() allows devm usage for
> resource subranges, such as the mmio resource for the platform device
> created to control host/device mode mux, which is a xhci extended
> capability, and sits inside the xhci mmio region.
>
> If managed device resources are not used then "parent" resource
> is released before subrange at driver removal as .remove callback is
> called before the devres list of resources for this device is walked
> and released.
>
> This has been observed with the xhci extended capability driver causing a
> use-after-free which is now fixed.
>
> An additional nice benefit is that error handling on driver initialisation
> is simplified much.
>
> Signed-off-by: Carsten Schmid <carsten_schmid@mentor.com>
> Tested-by: Carsten Schmid <carsten_schmid@mentor.com>
> ---
> Rationale:
> Use-after-free was reproduced on 4.14.102 and 4.14.129 kernel
> using unbind mechanism.
> echo 0000:00:15.0 > /sys/bus/pci/drivers/xhci_hcd/unbind
>
> Upstream version of driver is identical in the affected code.
> Fix was tested successfully on 4.14.129.
> Provided patch applies and compiles on v5.2.8 stable.
> As this is also a bugfix, please consider it to go to stable trees too.
How far back should it go, just 4.14? Was this caused by a specific
commit that you happened to notice?
thanks,
greg k-h
next prev parent reply other threads:[~2019-08-25 8:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 14:11 [Patch v5] usb: hcd: use managed device resources Schmid, Carsten
2019-08-25 8:29 ` Greg KH [this message]
2019-08-26 7:20 ` AW: " Schmid, Carsten
2019-08-26 7:28 ` Mathias Nyman
2019-08-26 8:09 ` AW: " Schmid, Carsten
2019-08-26 8:41 ` Mathias Nyman
2019-08-26 9:18 ` AW: " Schmid, Carsten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190825082949.GA4583@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Carsten_Schmid@mentor.com \
--cc=hdegoede@redhat.com \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.