From: Gao Xiang <gaoxiang25@huawei.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
<devel@driverdev.osuosl.org>, <elder@kernel.org>,
Viresh Kumar <vireshk@kernel.org>, <johan@kernel.org>,
<linux-kernel@vger.kernel.org>, <greybus-dev@lists.linaro.org>,
<yuchao0@huawei.com>
Subject: Re: [PATCH 1/9] staging: greybus: fix up SPDX comment in .h files
Date: Tue, 27 Aug 2019 17:20:36 +0800 [thread overview]
Message-ID: <20190827092036.GA138083@architecture4> (raw)
In-Reply-To: <20190827075802.GA29204@kroah.com>
Hi Greg,
On Tue, Aug 27, 2019 at 09:58:02AM +0200, Greg Kroah-Hartman wrote:
> On Mon, Aug 26, 2019 at 11:21:19AM +0530, Viresh Kumar wrote:
> > On 25-08-19, 07:54, Greg Kroah-Hartman wrote:
> > > When these files originally got an SPDX tag, I used // instead of /* */
> > > for the .h files. Fix this up to use // properly.
> > >
> > > Cc: Viresh Kumar <vireshk@kernel.org>
> > > Cc: Johan Hovold <johan@kernel.org>
> > > Cc: Alex Elder <elder@kernel.org>
> > > Cc: greybus-dev@lists.linaro.org
> > > Cc: devel@driverdev.osuosl.org
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > ---
> > > drivers/staging/greybus/firmware.h | 2 +-
> > > drivers/staging/greybus/gb-camera.h | 2 +-
> > > drivers/staging/greybus/gbphy.h | 2 +-
> > > drivers/staging/greybus/greybus.h | 2 +-
> > > drivers/staging/greybus/greybus_authentication.h | 2 +-
> > > drivers/staging/greybus/greybus_firmware.h | 2 +-
> > > drivers/staging/greybus/greybus_manifest.h | 2 +-
> > > drivers/staging/greybus/greybus_protocols.h | 2 +-
> > > drivers/staging/greybus/greybus_trace.h | 2 +-
> > > drivers/staging/greybus/hd.h | 2 +-
> > > drivers/staging/greybus/interface.h | 2 +-
> > > drivers/staging/greybus/manifest.h | 2 +-
> > > drivers/staging/greybus/module.h | 2 +-
> > > drivers/staging/greybus/operation.h | 2 +-
> > > drivers/staging/greybus/spilib.h | 2 +-
> > > drivers/staging/greybus/svc.h | 2 +-
> > > 16 files changed, 16 insertions(+), 16 deletions(-)
> >
> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> Thanks for all of the acks!
>
> greg k-h
I found similar issues of graybus when I tested the latest staging-testing
In file included from <command-line>:0:0:
./include/linux/greybus/greybus_protocols.h:45:2: error: unknown type name ‘__le16’
__le16 size; /* Size in bytes of header + payload */
^~~~~~
./include/linux/greybus/greybus_protocols.h:46:2: error: unknown type name ‘__le16’
__le16 operation_id; /* Operation unique id */
^~~~~~
./include/linux/greybus/greybus_protocols.h:47:2: error: unknown type name ‘__u8’
__u8 type; /* E.g GB_I2C_TYPE_* or GB_GPIO_TYPE_* */
^~~~
./include/linux/greybus/greybus_protocols.h:48:2: error: unknown type name ‘__u8’
__u8 result; /* Result of request (in responses only) */
^~~~
./include/linux/greybus/greybus_protocols.h:49:2: error: unknown type name ‘__u8’
__u8 pad[2]; /* must be zero (ignore when read) */
^~~~
./include/linux/greybus/greybus_protocols.h:58:2: error: unknown type name ‘__u8’
__u8 phase;
^~~~
./include/linux/greybus/greybus_protocols.h:88:2: error: unknown type name ‘__u8’
__u8 major;
^~~~
./include/linux/greybus/greybus_protocols.h:89:2: error: unknown type name ‘__u8’
__u8 minor;
^~~~
./include/linux/greybus/greybus_protocols.h:93:2: error: unknown type name ‘__u8’
__u8 major;
^~~~
./include/linux/greybus/greybus_protocols.h:94:2: error: unknown type name ‘__u8’
__u8 minor;
^~~~
./include/linux/greybus/greybus_protocols.h:98:2: error: unknown type name ‘__u8’
__u8 bundle_id;
^~~~
./include/linux/greybus/greybus_protocols.h:102:2: error: unknown type name ‘__u8’
__u8 major;
^~~~
./include/linux/greybus/greybus_protocols.h:103:2: error: unknown type name ‘__u8’
__u8 minor;
^~~~
./include/linux/greybus/greybus_protocols.h:108:2: error: unknown type name ‘__le16’
__le16 size;
^~~~~~
./include/linux/greybus/greybus_protocols.h:113:2: error: unknown type name ‘__u8’
__u8 data[0];
^~~~
./include/linux/greybus/greybus_protocols.h:118:2: error: unknown type name ‘__le16’
__le16 cport_id;
^~~~~~
./include/linux/greybus/greybus_protocols.h:122:2: error: unknown type name ‘__le16’
__le16 cport_id;
.. and other files...
Not very sure... but it seems it can be observed with allmodconfig or
CONFIG_KERNEL_HEADER_TEST=y and fail my compilation...
Hope that of some help (kind reminder...)
Thanks,
Gao Xiang
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2019-08-27 9:21 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-25 5:54 [PATCH 0/9] staging: move greybus core out of staging Greg Kroah-Hartman
2019-08-25 5:54 ` [PATCH 1/9] staging: greybus: fix up SPDX comment in .h files Greg Kroah-Hartman
2019-08-26 5:51 ` Viresh Kumar
2019-08-27 7:58 ` Greg Kroah-Hartman
2019-08-27 9:20 ` Gao Xiang [this message]
2019-08-27 15:43 ` Greg Kroah-Hartman
2019-08-27 16:01 ` Gao Xiang
2019-08-25 5:54 ` [PATCH 2/9] staging: greybus: remove license "boilerplate" Greg Kroah-Hartman
2019-08-26 5:52 ` Viresh Kumar
2019-08-27 15:37 ` Mark Greer
2019-08-25 5:54 ` [PATCH 3/9] staging: greybus: hd: Fix up some alignment checkpatch issues Greg Kroah-Hartman
2019-08-26 5:57 ` [greybus-dev] " Viresh Kumar
2019-08-25 5:54 ` [PATCH 4/9] staging: greybus: manifest: " Greg Kroah-Hartman
2019-08-26 6:11 ` [greybus-dev] " Viresh Kumar
2019-08-25 5:54 ` [PATCH 5/9] staging: greybus: log: " Greg Kroah-Hartman
2019-08-26 6:12 ` [greybus-dev] " Viresh Kumar
2019-08-25 5:54 ` [PATCH 6/9] staging: greybus: loopback: " Greg Kroah-Hartman
2019-08-26 6:12 ` [greybus-dev] " Viresh Kumar
2019-08-25 5:54 ` [PATCH 7/9] staging: greybus: move core include files to include/linux/greybus/ Greg Kroah-Hartman
2019-08-26 5:55 ` Viresh Kumar
2019-08-27 15:38 ` Mark Greer
2019-08-25 5:54 ` [PATCH 8/9] staging: greybus: move the greybus core to drivers/greybus Greg Kroah-Hartman
2019-08-26 6:13 ` [greybus-dev] " Viresh Kumar
2019-08-25 5:54 ` [PATCH 9/9] staging: greybus: move es2 to drivers/greybus/ Greg Kroah-Hartman
2019-08-26 6:14 ` [greybus-dev] " Viresh Kumar
2019-08-27 10:43 ` [greybus-dev] [PATCH 0/9] staging: move greybus core out of staging Alex Elder
2019-08-27 13:36 ` Dan Carpenter
2019-08-27 13:45 ` Greg Kroah-Hartman
2019-08-27 14:30 ` Rui Miguel Silva
2019-08-27 14:30 ` Rui Miguel Silva
2019-08-27 15:43 ` Greg KH
2019-08-27 15:43 ` Greg KH
2019-08-27 15:57 ` Rui Miguel Silva
2019-08-27 15:57 ` Rui Miguel Silva
2019-08-27 16:59 ` Greg KH
2019-08-27 16:59 ` Greg KH
2019-08-27 14:37 ` Dan Carpenter
2019-09-01 17:23 ` Pavel Machek
2019-09-01 17:23 ` Pavel Machek
2019-09-02 6:31 ` Greg Kroah-Hartman
2019-09-02 6:31 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827092036.GA138083@architecture4 \
--to=gaoxiang25@huawei.com \
--cc=devel@driverdev.osuosl.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.