Re: [PATCH] drivers/staging/exfat - by default, prohibit mount of fat/vfat

From: Gao Xiang <hsiangkao@aol.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: "Dave Chinner" <david@fromorbit.com>,
	"Valdis Klētnieks" <valdis.kletnieks@vt.edu>,
	"Christoph Hellwig" <hch@infradead.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Sasha Levin" <alexander.levin@microsoft.com>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/staging/exfat - by default, prohibit mount of fat/vfat
Date: Sun, 1 Sep 2019 11:26:02 +0800	[thread overview]
Message-ID: <20190901032556.GA10186@hsiangkao-HP-ZHAN-66-Pro-G1> (raw)
In-Reply-To: <20190901030514.GC1131@ZenIV.linux.org.uk>

Hi Al,

On Sun, Sep 01, 2019 at 04:05:14AM +0100, Al Viro wrote:
> On Sun, Sep 01, 2019 at 09:37:19AM +0800, Gao Xiang wrote:
> 
> > fs/orangefs/file.c
> >  19 static int flush_racache(struct inode *inode)
> 
> Just why the hell would _that_ one be a problem?  It's static in
> file; it can't pollute the namespace even if linked into the
> kernel.
> 
> Folks, let's keep at least some degree of sanity - this is sinking
> to the level of certain killfile denizens...

Thanks for your kind reply. I think in the same way.
And Christoph did many great suggestions for erofs, thanks him
for erofs, and I'm already fixed most of them, and some
suggestions I have no idea to do....
  1) add "erofs_" to all functions [1] [2];
  2) avoid sb_bread and use read_mapping_page, actually
      read_mapping_page will call block_read_full_page and
      buffer_heads still there;

and I don't know what erofs "rapidly turning" means, all great
suggestions I can fix them all, I have no idea it's a bad thing.

[1] https://lore.kernel.org/linux-fsdevel/20190830163910.GB29603@infradead.org/
[2] https://lore.kernel.org/linux-fsdevel/20190831064853.GA162401@architecture4/

Thanks,
Gao Xiang