From: Nicolas Iooss <nicolas.iooss@m4x.org>
To: selinux@vger.kernel.org
Subject: [PATCH 0/9] Fix issues found by static analyzers
Date: Sun, 1 Sep 2019 20:06:27 +0200 [thread overview]
Message-ID: <20190901180636.31586-1-nicolas.iooss@m4x.org> (raw)
Hi,
In August I ran several free static analyzers in order to find new
issues in the userspace code. I used:
* clang's static analyzer (with scripts/run-scan-build)
* https://lgtm.com/ (I wrote a simple configuration file to analyze the
C code, the results are available on
https://lgtm.com/projects/g/fishilico/selinux-for-lgtm/ )
* Facebook's Infer (https://fbinfer.com/, I wrote a script to invoke it
like clang's static analyzer)
Each analyzer gave many results, with several true bugs in them. Here
are patches that fix some of them. I will post the configuration files
and scripts I used separately.
Thanks,
Nicolas
Nicolas Iooss (9):
semodule-utils: fix comparison with argc
libsepol/cil: help static analyzers by aborting when an allocation
fails
libsepol: do not dereference a failed allocated pointer
libsepol: do not dereference scope if it can be NULL
libsepol: reset *p to NULL if sepol_module_package_create fails
libsepol/cil: do not dereference perm_value_to_cil when it has not
been allocated
python/chcat: remove unnecessary assignment
python/sepolicy: remove unnecessary pass statement
libsepol/tests: do not dereference a NULL pointer
libsepol/cil/src/cil_binary.c | 10 ++++++----
libsepol/cil/src/cil_mem.c | 5 +++++
libsepol/src/avrule_block.c | 3 ++-
libsepol/src/kernel_to_cil.c | 8 +++++---
libsepol/src/kernel_to_conf.c | 8 +++++---
libsepol/src/module.c | 4 +++-
libsepol/tests/test-common.c | 11 +++++++----
python/chcat/chcat | 1 -
python/sepolicy/sepolicy/__init__.py | 1 -
semodule-utils/semodule_package/semodule_unpackage.c | 2 +-
10 files changed, 34 insertions(+), 19 deletions(-)
--
2.22.0
next reply other threads:[~2019-09-01 18:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-01 18:06 Nicolas Iooss [this message]
2019-09-01 18:06 ` [PATCH 1/9] semodule-utils: fix comparison with argc Nicolas Iooss
2019-09-01 18:06 ` [PATCH 2/9] libsepol/cil: help static analyzers by aborting when an allocation fails Nicolas Iooss
2019-09-10 18:48 ` [Non-DoD Source] " jwcart2
2019-09-01 18:06 ` [PATCH 3/9] libsepol: do not dereference a failed allocated pointer Nicolas Iooss
2019-09-10 18:52 ` [Non-DoD Source] " jwcart2
2019-09-10 20:11 ` jwcart2
2019-09-01 18:06 ` [PATCH 4/9] libsepol: do not dereference scope if it can be NULL Nicolas Iooss
2019-09-01 18:06 ` [PATCH 5/9] libsepol: reset *p to NULL if sepol_module_package_create fails Nicolas Iooss
2019-09-01 18:06 ` [PATCH 6/9] libsepol/cil: do not dereference perm_value_to_cil when it has not been allocated Nicolas Iooss
2019-09-01 18:06 ` [PATCH 7/9] python/chcat: remove unnecessary assignment Nicolas Iooss
2019-09-01 18:06 ` [PATCH 8/9] python/sepolicy: remove unnecessary pass statement Nicolas Iooss
2019-09-01 18:06 ` [PATCH 9/9] libsepol/tests: do not dereference a NULL pointer Nicolas Iooss
2019-09-16 16:46 ` [Non-DoD Source] [PATCH 0/9] Fix issues found by static analyzers jwcart2
2019-09-17 15:01 ` jwcart2
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190901180636.31586-1-nicolas.iooss@m4x.org \
--to=nicolas.iooss@m4x.org \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.