From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Shiyang Ruan <ruansy.fnst@cn.fujitsu.com>
Cc: Christoph Hellwig <hch@lst.de>,
Goldwyn Rodrigues <rgoldwyn@suse.de>,
linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org,
david@fromorbit.com, riteshh@linux.ibm.com
Subject: Re: [PATCH v3 0/15] Btrfs iomap
Date: Mon, 2 Sep 2019 21:29:35 -0700 [thread overview]
Message-ID: <20190903042935.GD5340@magnolia> (raw)
In-Reply-To: <4d039e8e-dc35-8092-4ee0-4a2e0f43f233@cn.fujitsu.com>
On Tue, Sep 03, 2019 at 11:51:24AM +0800, Shiyang Ruan wrote:
>
>
> On 9/3/19 12:43 AM, Christoph Hellwig wrote:
> > On Sun, Sep 01, 2019 at 03:08:21PM -0500, Goldwyn Rodrigues wrote:
> > > This is an effort to use iomap for btrfs. This would keep most
> > > responsibility of page handling during writes in iomap code, hence
> > > code reduction. For CoW support, changes are needed in iomap code
> > > to make sure we perform a copy before the write.
> > > This is in line with the discussion we had during adding dax support in
> > > btrfs.
> >
> > This looks pretty good modulo a few comments.
> >
> > Can you please convert the XFS code to use your two iomaps for COW
> > approach as well to validate it?
>
> Hi,
>
> The XFS part of dax CoW support has been implementing recently. Please
> review this[1] if necessary. It's based on this iomap patchset(the 1st
> version), and uses the new srcmap.
>
> [1]: https://lkml.org/lkml/2019/7/31/449
It sure would be nice to have (a) this patchset of Goldwyn's cleaned up
a bit per the review comments and (b) the XFS DAX COW series rebased on
that (instead of a month-old submission). ;)
--D
> --
> Thanks,
> Shiyang Ruan.
> >
> > Also the iomap_file_dirty helper would really benefit from using the
> > two iomaps, any chance you could look into improving it to use your
> > new infrastructure?
> >
> >
>
>
>
next prev parent reply other threads:[~2019-09-03 4:29 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-01 20:08 [PATCH v3 0/15] Btrfs iomap Goldwyn Rodrigues
2019-09-01 20:08 ` [PATCH 01/15] iomap: Introduce CONFIG_FS_IOMAP_DEBUG Goldwyn Rodrigues
2019-09-01 20:50 ` Darrick J. Wong
2019-09-02 16:29 ` Christoph Hellwig
2019-09-02 17:09 ` Darrick J. Wong
2019-09-02 17:18 ` Christoph Hellwig
2019-09-03 15:06 ` Darrick J. Wong
2019-09-01 20:08 ` [PATCH 02/15] iomap: Use a IOMAP_COW/srcmap for a read-modify-write I/O Goldwyn Rodrigues
2019-09-02 16:31 ` Christoph Hellwig
2019-09-03 3:18 ` Darrick J. Wong
2019-09-03 14:12 ` Goldwyn Rodrigues
2019-09-03 14:05 ` Goldwyn Rodrigues
2019-09-03 14:56 ` Darrick J. Wong
2019-09-01 20:08 ` [PATCH 03/15] iomap: Read page from srcmap for IOMAP_COW Goldwyn Rodrigues
2019-09-02 16:31 ` Christoph Hellwig
2019-09-02 17:01 ` Darrick J. Wong
2019-09-02 17:13 ` Christoph Hellwig
2019-09-01 20:08 ` [PATCH 04/15] btrfs: Eliminate PagePrivate for btrfs data pages Goldwyn Rodrigues
2019-09-01 20:08 ` [PATCH 05/15] btrfs: Add a simple buffered iomap write Goldwyn Rodrigues
2019-09-01 20:08 ` [PATCH 06/15] btrfs: Add CoW in iomap based writes Goldwyn Rodrigues
2019-09-01 20:08 ` [PATCH 07/15] btrfs: remove buffered write code made unnecessary Goldwyn Rodrigues
2019-09-01 20:08 ` [PATCH 08/15] fs: Export generic_file_buffered_read() Goldwyn Rodrigues
2019-09-01 20:08 ` [PATCH 09/15] btrfs: basic direct read operation Goldwyn Rodrigues
2019-09-01 20:08 ` [PATCH 10/15] btrfs: Carve out btrfs_get_extent_map_write() out of btrfs_get_blocks_write() Goldwyn Rodrigues
2019-09-01 20:08 ` [PATCH 11/15] btrfs: Rename __endio_write_update_ordered() to btrfs_update_ordered_extent() Goldwyn Rodrigues
2019-09-01 20:08 ` [PATCH 12/15] iomap: use a function pointer for dio submits Goldwyn Rodrigues
2019-09-02 16:41 ` Christoph Hellwig
2019-09-01 20:08 ` [PATCH 13/15] btrfs: Use iomap_dio_rw for performing direct I/O writes Goldwyn Rodrigues
2019-09-01 20:08 ` [PATCH 14/15] btrfs: Remove btrfs_dio_data and __btrfs_direct_write Goldwyn Rodrigues
2019-09-01 20:08 ` [PATCH 15/15] btrfs: update inode size during bio completion Goldwyn Rodrigues
2019-09-02 16:43 ` [PATCH v3 0/15] Btrfs iomap Christoph Hellwig
2019-09-03 3:51 ` Shiyang Ruan
2019-09-03 4:29 ` Darrick J. Wong [this message]
2019-09-03 5:00 ` Shiyang Ruan
2019-09-03 6:21 ` Christoph Hellwig
2019-09-03 13:44 ` Goldwyn Rodrigues
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190903042935.GD5340@magnolia \
--to=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=rgoldwyn@suse.de \
--cc=riteshh@linux.ibm.com \
--cc=ruansy.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.