From: Vinod Koul <vkoul@kernel.org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: dmaengine@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2] dmaengine: rcar-dmac: Fix DMACHCLR handling if iommu is mapped
Date: Wed, 4 Sep 2019 11:36:14 +0530 [thread overview]
Message-ID: <20190904060614.GF2672@vkoul-mobl> (raw)
In-Reply-To: <1567424643-26629-1-git-send-email-yoshihiro.shimoda.uh@renesas.com>
On 02-09-19, 20:44, Yoshihiro Shimoda wrote:
> The commit 20c169aceb45 ("dmaengine: rcar-dmac: clear pertinence
> number of channels") forgets to clear the last channel by
> DMACHCLR in rcar_dmac_init() (and doesn't need to clear the first
> channel) if iommu is mapped to the device. So, this patch fixes it
> by using "channels_mask" bitfield.
>
> Note that the hardware and driver don't support more than 32 bits
> in DMACHCLR register anyway, so this patch should reject more than
> 32 channels in rcar_dmac_parse_of().
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2019-09-04 6:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 11:44 [PATCH v2] dmaengine: rcar-dmac: Fix DMACHCLR handling if iommu is mapped Yoshihiro Shimoda
2019-09-04 6:06 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904060614.GF2672@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.