From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Krzysztof Wilczynski <kw@linux.com>,
Bjorn Helgaas <helgaas@kernel.org>,
KY Srinivasan <kys@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Sasha Levin <sashal@kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>
Subject: Re: [PATCH v3] PCI: hv: Make functions static
Date: Wed, 4 Sep 2019 15:27:37 +0100 [thread overview]
Message-ID: <20190904142737.GA28184@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <DM6PR21MB13372349374A473FF98AD7BCCAA20@DM6PR21MB1337.namprd21.prod.outlook.com>
On Thu, Aug 29, 2019 at 03:50:47PM +0000, Haiyang Zhang wrote:
>
>
> > -----Original Message-----
> > From: Krzysztof Wilczynski <kswilczynski@gmail.com> On Behalf Of Krzysztof
> > Wilczynski
> > Sent: Thursday, August 29, 2019 2:17 AM
> > To: Bjorn Helgaas <helgaas@kernel.org>
> > Cc: KY Srinivasan <kys@microsoft.com>; Haiyang Zhang
> > <haiyangz@microsoft.com>; Stephen Hemminger
> > <sthemmin@microsoft.com>; Sasha Levin <sashal@kernel.org>; Lorenzo
> > Pieralisi <lorenzo.pieralisi@arm.com>; linux-pci@vger.kernel.org; linux-
> > kernel@vger.kernel.org; linux-hyperv@vger.kernel.org
> > Subject: [PATCH v3] PCI: hv: Make functions static
> >
> > Functions hv_read_config_block(), hv_write_config_block() and
> > hv_register_block_invalidate() are not used anywhere else and are local to
> > drivers/pci/controller/pci-hyperv.c,
> > and do not need to be in global scope, so make these static.
> >
> > Resolve following compiler warning that can be seen when building with
> > warnings enabled (W=1):
> >
> > drivers/pci/controller/pci-hyperv.c:933:5: warning:
> > no previous prototype for ‘hv_read_config_block’
> > [-Wmissing-prototypes]
> >
> > drivers/pci/controller/pci-hyperv.c:1013:5: warning:
> > no previous prototype for ‘hv_write_config_block’
> > [-Wmissing-prototypes]
> >
> > drivers/pci/controller/pci-hyperv.c:1082:5: warning:
> > no previous prototype for ‘hv_register_block_invalidate’
> > [-Wmissing-prototypes]
> >
> > Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
>
> Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
This patch should go via the net tree - the code it is fixing
is queued there, I will drop this patch from the PCI review
queue.
If it helps:
Acked-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
next prev parent reply other threads:[~2019-09-04 14:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 15:41 [PATCH] PCI: hv: Make functions only used locally static in pci-hyperv.c Krzysztof Wilczynski
2019-08-28 22:18 ` [PATCH v2] " Krzysztof Wilczynski
2019-08-28 22:32 ` Haiyang Zhang
2019-08-29 0:08 ` Krzysztof Wilczynski
2019-08-29 9:17 ` [PATCH v3] PCI: hv: Make functions static Krzysztof Wilczynski
2019-08-29 15:50 ` Haiyang Zhang
2019-09-04 14:27 ` Lorenzo Pieralisi [this message]
2019-09-04 14:36 ` Krzysztof Wilczynski
2019-08-28 22:26 ` [PATCH] PCI: hv: Make functions only used locally static in pci-hyperv.c Bjorn Helgaas
2019-08-28 23:33 ` Krzysztof Wilczynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904142737.GA28184@e121166-lin.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=haiyangz@microsoft.com \
--cc=helgaas@kernel.org \
--cc=kw@linux.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.