Re: [PATCH 1/3] regulator: fixed: add possibility to enable by clock

From: Mark Brown <broonie@kernel.org>
To: Philippe Schenker <philippe.schenker@toradex.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Liam Girdwood <lgirdwood@gmail.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Max Krummenacher <max.krummenacher@toradex.com>,
	Rob Herring <robh+dt@kernel.org>,
	Stefan Agner <stefan.agner@toradex.com>,
	Marcel Ziswiler <marcel.ziswiler@toradex.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Luka Pivk <luka.pivk@toradex.com>
Subject: Re: [PATCH 1/3] regulator: fixed: add possibility to enable by clock
Date: Thu, 5 Sep 2019 19:06:15 +0100	[thread overview]
Message-ID: <20190905180615.GG4053@sirena.co.uk> (raw)
In-Reply-To: <20190903080336.32288-2-philippe.schenker@toradex.com>

[-- Attachment #1: Type: text/plain, Size: 768 bytes --]

On Tue, Sep 03, 2019 at 08:03:46AM +0000, Philippe Schenker wrote:
> This commit adds the possibility to choose the compatible
> "regulator-fixed-clock" in devicetree.
> 
> This is a special regulator-fixed that has to have a clock, from which
> the regulator gets switched on and off.

This seems conceptually fine.  Minor issues though:

> +static int reg_clock_is_enabled(struct regulator_dev *rdev)
> +{
> +	struct fixed_voltage_data *priv = rdev_get_drvdata(rdev);
> +
> +	if (priv->clk_enable_counter > 0)
> +		return 1;
> +
> +	return 0;
> +}

This could just be return priv->clk_enable_counter > 0 - ideally the
clock API would let us query if the clock is enabled but that might be a
bit confused anyway given that it's possibly shared.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]