From: Allison Collins <allison.henderson@oracle.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH v2 16/21] xfsprogs: Add xfs_attr_set_deferred and xfs_attr_remove_deferred
Date: Thu, 5 Sep 2019 15:18:50 -0700 [thread overview]
Message-ID: <20190905221855.17555-17-allison.henderson@oracle.com> (raw)
In-Reply-To: <20190905221855.17555-1-allison.henderson@oracle.com>
These routines set up set and start a new deferred attribute
operation. These functions are meant to be called by other
code needing to initiate a deferred attribute operation.
New helper function xfs_attr_item_init also added
Signed-off-by: Allison Collins <allison.henderson@oracle.com>
---
libxfs/xfs_attr.c | 85 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
libxfs/xfs_attr.h | 5 ++++
2 files changed, 90 insertions(+)
diff --git a/libxfs/xfs_attr.c b/libxfs/xfs_attr.c
index 919a5da..43ecf45 100644
--- a/libxfs/xfs_attr.c
+++ b/libxfs/xfs_attr.c
@@ -24,6 +24,7 @@
#include "xfs_trans_space.h"
#include "xfs_trace.h"
#include "xfs_attr_item.h"
+#include "xfs_attr.h"
/*
* xfs_attr.c
@@ -588,6 +589,70 @@ out_trans_cancel:
goto out_unlock;
}
+STATIC int
+xfs_attr_item_init(
+ struct xfs_inode *dp, /* inode for attr operation */
+ struct xfs_trans *tp, /* transaction for attr op */
+ struct xfs_name *name, /* attr name, len and flags */
+ const unsigned char *value, /* attr value */
+ unsigned int valuelen, /* attr value len */
+ int op_flags, /* op flag (set or remove) */
+ struct xfs_attr_item **attr) /* new xfs_attr_item */
+{
+
+ struct xfs_attr_item *new;
+ char *name_value;
+
+ /*
+ * All set operations must have a name but not necessarily a value.
+ */
+ if (!name->len) {
+ ASSERT(0);
+ return -EINVAL;
+ }
+
+ new = kmem_alloc(XFS_ATTR_ITEM_SIZEOF(name->len, valuelen),
+ KM_NOFS);
+ name_value = ((char *)new) + sizeof(struct xfs_attr_item);
+ memset(new, 0, XFS_ATTR_ITEM_SIZEOF(name->len, valuelen));
+ new->xattri_ip = dp;
+ new->xattri_op_flags = op_flags;
+ new->xattri_name_len = name->len;
+ new->xattri_value_len = valuelen;
+ new->xattri_flags = name->type;
+ memcpy(&name_value[0], name->name, name->len);
+ new->xattri_name = name_value;
+ new->xattri_value = name_value + name->len;
+
+ if (valuelen > 0)
+ memcpy(&name_value[name->len], value, valuelen);
+
+ *attr = new;
+ return 0;
+}
+
+/* Sets an attribute for an inode as a deferred operation */
+int
+xfs_attr_set_deferred(
+ struct xfs_inode *dp,
+ struct xfs_trans *tp,
+ struct xfs_name *name,
+ const unsigned char *value,
+ unsigned int valuelen)
+{
+ struct xfs_attr_item *new;
+ int error = 0;
+
+ error = xfs_attr_item_init(dp, tp, name, value, valuelen,
+ XFS_ATTR_OP_FLAGS_SET, &new);
+ if (error)
+ return error;
+
+ xfs_defer_add(tp, XFS_DEFER_OPS_TYPE_ATTR, &new->xattri_list);
+
+ return 0;
+}
+
/*
* Generic handler routine to remove a name from an attribute list.
* Transitions attribute list from Btree to shortform as necessary.
@@ -669,6 +734,26 @@ out:
return error;
}
+/* Removes an attribute for an inode as a deferred operation */
+int
+xfs_attr_remove_deferred(
+ struct xfs_inode *dp,
+ struct xfs_trans *tp,
+ struct xfs_name *name)
+{
+
+ struct xfs_attr_item *new;
+
+ int error = xfs_attr_item_init(dp, tp, name, NULL, 0,
+ XFS_ATTR_OP_FLAGS_REMOVE, &new);
+ if (error)
+ return error;
+
+ xfs_defer_add(tp, XFS_DEFER_OPS_TYPE_ATTR, &new->xattri_list);
+
+ return 0;
+}
+
/*========================================================================
* External routines when attribute list is inside the inode
*========================================================================*/
diff --git a/libxfs/xfs_attr.h b/libxfs/xfs_attr.h
index a651f4e..743d00e 100644
--- a/libxfs/xfs_attr.h
+++ b/libxfs/xfs_attr.h
@@ -188,5 +188,10 @@ bool xfs_attr_namecheck(const void *name, size_t length);
int xfs_attr_args_init(struct xfs_da_args *args, struct xfs_inode *dp,
struct xfs_name *name);
int xfs_attr_calc_size(struct xfs_da_args *args, int *local);
+int xfs_attr_set_deferred(struct xfs_inode *dp, struct xfs_trans *tp,
+ struct xfs_name *name, const unsigned char *value,
+ unsigned int valuelen);
+int xfs_attr_remove_deferred(struct xfs_inode *dp, struct xfs_trans *tp,
+ struct xfs_name *name);
#endif /* __XFS_ATTR_H__ */
--
2.7.4
next prev parent reply other threads:[~2019-09-05 22:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 22:18 [PATCH v2 00/21] Delayed Attributes Allison Collins
2019-09-05 22:18 ` [PATCH v2 01/21] xfsprogs: Replace attribute parameters with struct xfs_name Allison Collins
2019-09-05 22:18 ` [PATCH v2 02/21] xfsprogs: Embed struct xfs_name in xfs_da_args Allison Collins
2019-09-05 22:18 ` [PATCH v2 03/21] xfsprogs: Add xfs_dabuf defines Allison Collins
2019-09-05 22:18 ` [PATCH v2 04/21] xfsprogs: Add xfs_has_attr and subroutines Allison Collins
2019-09-05 22:18 ` [PATCH v2 05/21] xfsprogs: Factor out new helper functions xfs_attr_rmtval_set Allison Collins
2019-09-05 22:18 ` [PATCH v2 06/21] xfsprogs: Factor up trans handling in xfs_attr3_leaf_flipflags Allison Collins
2019-09-05 22:18 ` [PATCH v2 07/21] xfsprogs: Factor out xfs_attr_leaf_addname helper Allison Collins
2019-09-05 22:18 ` [PATCH v2 08/21] xfsprogs: Factor up commit from xfs_attr_try_sf_addname Allison Collins
2019-09-05 22:18 ` [PATCH v2 09/21] xfsprogs: Factor up trans roll from xfs_attr3_leaf_setflag Allison Collins
2019-09-05 22:18 ` [PATCH v2 10/21] xfsprogs: Add xfs_attr3_leaf helper functions Allison Collins
2019-09-05 22:18 ` [PATCH v2 11/21] xfsprogs: Factor out xfs_attr_rmtval_invalidate Allison Collins
2019-09-05 22:18 ` [PATCH v2 12/21] xfsprogs: Factor up trans roll in xfs_attr3_leaf_clearflag Allison Collins
2019-09-05 22:18 ` [PATCH v2 13/21] xfsprogs: Add delay context to xfs_da_args Allison Collins
2019-09-05 22:18 ` [PATCH v2 14/21] xfsprogs: Add delayed attribute routines Allison Collins
2019-09-05 22:18 ` [PATCH v2 15/21] xfsprogs: Set up infastructure for deferred attribute operations Allison Collins
2019-09-05 22:18 ` Allison Collins [this message]
2019-09-05 22:18 ` [PATCH v2 17/21] xfsprogs: Add feature bit XFS_SB_FEAT_INCOMPAT_LOG_DELATTR Allison Collins
2019-09-05 22:18 ` [PATCH v2 18/21] xfsprogs: Enable delayed attributes Allison Collins
2019-09-05 22:18 ` [PATCH v2 19/21] xfs_io: Add delayed attributes error tag Allison Collins
2019-09-05 22:18 ` [PATCH v2 20/21] xfsprogs: Add log item printing for ATTRI and ATTRD Allison Collins
2019-09-05 22:18 ` [PATCH v2 21/21] xfsprogs: Add delayed attribute flag to cmd Allison Collins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190905221855.17555-17-allison.henderson@oracle.com \
--to=allison.henderson@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.