All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Derrick Stolee" <stolee@gmail.com>,
	"Taylor Blau" <me@ttaylorr.com>
Subject: [PATCH 0/2] a few commit-graph improvements
Date: Sat, 7 Sep 2019 00:58:48 -0400	[thread overview]
Message-ID: <20190907045848.GA24515@sigill.intra.peff.net> (raw)

We've been playing with commit graphs at GitHub and found a few bits of
low-hanging fruit (one liners -- it doesn't get any lower than that).

The first one is actually a resurrection of a patch from March:

  https://public-inbox.org/git/20190322102817.19708-1-szeder.dev@gmail.com/

where the progress bar sometimes prints nonsense. There's some
discussion in that thread about how we could sometimes show a real
percentage instead of a counting-up progress meter. But given the number
of corner cases discussed, and the fact that nothing has happened for 6
months, I think we should first make sure we're always doing the
_correct_ thing, and then people can build a nicer meter on top if they
want to.

The second is a fix for a small memory "leak", but it makes a big
difference.

  [1/2]: commit-graph: don't show progress percentages while expanding reachable commits
  [2/2]: commit-graph: turn off save_commit_buffer

 builtin/commit-graph.c | 2 ++
 commit-graph.c         | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

-Peff

             reply	other threads:[~2019-09-07  4:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-07  4:58 Jeff King [this message]
2019-09-07  5:01 ` [PATCH 1/2] commit-graph: don't show progress percentages while expanding reachable commits Jeff King
2019-09-07 10:34   ` SZEDER Gábor
2019-09-07 18:54     ` Taylor Blau
2019-09-27 18:54   ` Linus Torvalds
2019-09-07  5:04 ` [PATCH 2/2] commit-graph: turn off save_commit_buffer Jeff King
2019-09-07 18:56   ` Taylor Blau
2019-09-08 10:31     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190907045848.GA24515@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylorr.com \
    --cc=stolee@gmail.com \
    --cc=szeder.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.