From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: git@vger.kernel.org, stolee@gmail.com, gitster@pobox.com
Subject: Re: [PATCH v2] cache-tree: do not lazy-fetch merge tree
Date: Tue, 10 Sep 2019 14:49:20 +0200 [thread overview]
Message-ID: <20190910124920.GI32087@szeder.dev> (raw)
In-Reply-To: <20190909190130.146613-1-jonathantanmy@google.com>
On Mon, Sep 09, 2019 at 12:01:30PM -0700, Jonathan Tan wrote:
> diff --git a/t/t0410-partial-clone.sh b/t/t0410-partial-clone.sh
> index 6415063980..3e434b6a81 100755
> --- a/t/t0410-partial-clone.sh
> +++ b/t/t0410-partial-clone.sh
> @@ -492,6 +492,20 @@ test_expect_success 'gc stops traversal when a missing but promised object is re
> ! grep "$TREE_HASH" out
> '
>
> +test_expect_success 'do not fetch when checking existence of tree we construct ourselves' '
> + rm -rf repo &&
> + test_create_repo repo &&
> + test_commit -C repo base &&
> + test_commit -C repo side1 &&
> + git -C repo checkout base &&
> + test_commit -C repo side2 &&
> +
> + git -C repo config core.repositoryformatversion 1 &&
> + git -C repo config extensions.partialclone "arbitrary string" &&
> +
> + git -C repo cherry-pick side1
> +'
> +
Sidenote, just curious: did you originally intend to add this test
before the test script sources 'lib-httpd.sh', or you were about to
append it at the end as usual, but then noticed the warning comment
telling you not to do so?
> . "$TEST_DIRECTORY"/lib-httpd.sh
> start_httpd
next prev parent reply other threads:[~2019-09-10 12:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 19:42 [PATCH] cache-tree: do not lazy-fetch merge tree Jonathan Tan
2019-09-04 1:37 ` Derrick Stolee
2019-09-04 22:35 ` Jonathan Tan
2019-09-04 23:35 ` Junio C Hamano
2019-09-09 19:01 ` [PATCH v2] " Jonathan Tan
2019-09-09 19:55 ` Junio C Hamano
2019-09-09 21:05 ` Junio C Hamano
2019-09-09 22:21 ` Jeff King
2019-09-10 1:09 ` Junio C Hamano
2019-09-10 18:15 ` Jonathan Tan
2019-09-10 12:49 ` SZEDER Gábor [this message]
2019-09-10 18:19 ` Jonathan Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190910124920.GI32087@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.