From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH 02/11] gpiolib: introduce devm_fwnode_gpiod_get_index()
Date: Fri, 13 Sep 2019 11:14:02 -0700 [thread overview]
Message-ID: <20190913181402.GB237523@dtor-ws> (raw)
In-Reply-To: <CACRpkdZjZZKQqkN-HC11PJ5SgZbZd1Gnbeh8ApJ7+cS1eOOMbw@mail.gmail.com>
On Thu, Sep 12, 2019 at 10:48:13AM +0100, Linus Walleij wrote:
> On Wed, Sep 11, 2019 at 8:52 AM Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
>
> > devm_fwnode_get_index_gpiod_from_child() is too long, besides the fwnode
> > in question does not have to be a child of device node. Let's rename it
> > to devm_fwnode_gpiod_get_index() and keep the old name for compatibility
> > for now.
> >
> > Also let's add a devm_fwnode_gpiod_get() wrapper as majority of the
> > callers need a single GPIO.
> >
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
> The patch is good because this is in line with Rusty Russells API
> manifesto:
>
> 7. The obvious use is (probably) the correct one.
> 6. The name tells you how to use it.
>
> It doesn't apply to my "devel" branch as of now:
> https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git/log/?h=devel
>
> If you rebase this and the next patch and send them separately I
> am willing to apply them already for v5.4 to easy your refactoring
> work during the v5.5 cycle here, provided we try to fix up the old users
> ASAP and delete the compatibility fallbacks in the near future.
Done.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2019-09-13 18:14 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 7:52 [PATCH 00/11] Add support for software nodes to gpiolib Dmitry Torokhov
2019-09-11 7:52 ` [PATCH 01/11] gpiolib: of: add a fallback for wlf,reset GPIO name Dmitry Torokhov
2019-09-12 9:30 ` Linus Walleij
2019-09-11 7:52 ` [PATCH 02/11] gpiolib: introduce devm_fwnode_gpiod_get_index() Dmitry Torokhov
2019-09-11 17:01 ` Andy Shevchenko
2019-09-12 9:35 ` Linus Walleij
2019-09-12 9:48 ` Linus Walleij
2019-09-13 18:14 ` Dmitry Torokhov [this message]
2019-09-11 7:52 ` [PATCH 03/11] gpiolib: introduce fwnode_gpiod_get_index() Dmitry Torokhov
2019-09-12 9:50 ` Linus Walleij
2019-09-11 7:52 ` [PATCH 04/11] net: phylink: switch to using fwnode_gpiod_get_index() Dmitry Torokhov
2019-09-11 9:25 ` Andy Shevchenko
2019-09-11 9:39 ` Russell King - ARM Linux admin
2019-09-11 9:46 ` Andy Shevchenko
2019-09-11 9:49 ` Russell King - ARM Linux admin
2019-09-11 9:55 ` Dmitry Torokhov
2019-09-11 10:10 ` Russell King - ARM Linux admin
2019-09-11 16:52 ` Andy Shevchenko
2019-09-11 9:51 ` Dmitry Torokhov
2019-09-12 9:41 ` Linus Walleij
2019-09-12 13:44 ` Andy Shevchenko
2019-09-12 13:52 ` Russell King - ARM Linux admin
2019-09-11 7:52 ` [PATCH 05/11] net: mdio: " Dmitry Torokhov
2019-09-11 7:52 ` [PATCH 06/11] drm/bridge: ti-tfp410: " Dmitry Torokhov
2019-09-20 23:12 ` Laurent Pinchart
2019-09-23 15:03 ` Heikki Krogerus
2019-09-23 16:00 ` Laurent Pinchart
2019-09-11 7:52 ` [PATCH 07/11] gpliolib: make fwnode_get_named_gpiod() static Dmitry Torokhov
2019-09-11 7:52 ` [PATCH 08/11] gpiolib: of: tease apart of_find_gpio() Dmitry Torokhov
2019-09-11 17:10 ` Andy Shevchenko
2019-09-11 7:52 ` [PATCH 09/11] gpiolib: of: tease apart acpi_find_gpio() Dmitry Torokhov
2019-09-11 17:12 ` Andy Shevchenko
2019-09-11 7:52 ` [PATCH 10/11] gpiolib: consolidate fwnode GPIO lookups Dmitry Torokhov
2019-09-11 7:52 ` [PATCH 11/11] gpiolib: add support for software nodes Dmitry Torokhov
2019-09-11 17:13 ` [PATCH 00/11] Add support for software nodes to gpiolib Andy Shevchenko
2019-09-12 9:55 ` Linus Walleij
2019-09-12 9:55 ` Linus Walleij
2019-09-17 0:22 ` Dmitry Torokhov
2019-09-17 0:22 ` Dmitry Torokhov
2019-09-30 22:44 ` Dmitry Torokhov
2019-09-30 22:44 ` Dmitry Torokhov
2019-10-04 21:44 ` Linus Walleij
2019-10-04 21:44 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190913181402.GB237523@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.