From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Mimi Zohar <zohar@linux.ibm.com>
Cc: linux-integrity@vger.kernel.org,
Roberto Sassu <roberto.sassu@huawei.com>,
Petr Vorel <pvorel@suse.cz>
Subject: Re: [PATCH] selftest/trustedkeys: TPM 1.2 trusted keys test
Date: Mon, 16 Sep 2019 10:48:05 +0300 [thread overview]
Message-ID: <20190916074805.GA26608@linux.intel.com> (raw)
In-Reply-To: <20190916073552.GD4859@linux.intel.com>
On Mon, Sep 16, 2019 at 10:35:52AM +0300, Jarkko Sakkinen wrote:
> On Sun, Sep 15, 2019 at 11:27:51PM -0400, Mimi Zohar wrote:
> > On Sun, 2019-09-15 at 16:52 -0400, Mimi Zohar wrote:
> > > On Fri, 2019-09-13 at 15:08 +0100, Jarkko Sakkinen wrote:
> > > > On Wed, Sep 11, 2019 at 08:00:40AM -0400, Mimi Zohar wrote:
> > > > > On Tue, 2019-09-10 at 19:24 -0400, Mimi Zohar wrote:
> > > > > > On Tue, 2019-09-10 at 19:18 -0400, Mimi Zohar wrote:
> > > > > > > Create, save and load trusted keys test
> > > > > >
> > > > > > Creating trusted keys is failing with the following messages. Any idea why?
> > > > > >
> > > > > > [ 147.014653] tpm tpm0: A TPM error (34) occurred attempting to a send a command
> > > > > > [ 147.014678] trusted_key: srkseal failed (-1)
> > > > > > [ 147.014687] trusted_key: key_seal failed (-1)
> > > > >
> > > > > This is a regression, that needs to be resolved. The test works on
> > > > > kernels prior to 5.1.
> > > >
> > > > It breaks on 5.2?
> > >
> > > No, the regression is in 5.1.
> > >
> > > >
> > > > Can you bisect the failing commit?
> > >
> > > git bisect start -- drivers/char/tpm/
> > > git bisect bad
> > > git bisect good v5.0
> > >
> > > # first bad commit: [412eb585587a1dc43c9622db79de9663b6c4c238] tpm:
> > > use tpm_buf in tpm_transmit_cmd() as the IO parameter
> >
> > In tpm_send(), setting buf.data directly to cmd, instead of calling
> > tpm_buf_init() fixes the problem.
>
> I see. Obviously memcpy() does not tpm_buf length. The implementation is
> kind of clunky but the point is to move building the tpm_buf to the
> caller (which is soon possible thanks to Sumit's patches).
>
> I sent a fix candidate.
Ugh. Sorry about the "fix candidate". Your fix is the way it should be
done. I'll put background to it once I've slept a bit.
/Jarkko
next prev parent reply other threads:[~2019-09-16 7:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 23:18 [PATCH] selftest/trustedkeys: TPM 1.2 trusted keys test Mimi Zohar
2019-09-10 23:24 ` Mimi Zohar
2019-09-11 12:00 ` Mimi Zohar
2019-09-13 14:08 ` Jarkko Sakkinen
2019-09-15 20:52 ` Mimi Zohar
2019-09-16 3:27 ` Mimi Zohar
2019-09-16 7:35 ` Jarkko Sakkinen
2019-09-16 7:48 ` Jarkko Sakkinen [this message]
2019-09-16 11:36 ` Mimi Zohar
2019-09-16 7:42 ` Jerry Snitselaar
2019-09-16 10:44 ` Sumit Garg
2019-09-16 14:00 ` Jerry Snitselaar
2019-09-16 11:52 ` Mimi Zohar
2019-09-16 14:28 ` Jerry Snitselaar
2019-09-16 7:15 ` Jarkko Sakkinen
2019-10-11 12:34 ` Jarkko Sakkinen
2019-10-11 13:01 ` Jarkko Sakkinen
2019-10-11 13:21 ` Mimi Zohar
2019-10-14 19:57 ` Jarkko Sakkinen
2019-10-22 14:43 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190916074805.GA26608@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=linux-integrity@vger.kernel.org \
--cc=pvorel@suse.cz \
--cc=roberto.sassu@huawei.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.