From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Andrew Murray <andrew.murray@arm.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Bjorn Helgaas <bhelgaas@google.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Vidya Sagar <vidyas@nvidia.com>,
Thierry Reding <treding@nvidia.com>,
linux-pci@vger.kernel.org, YueHaibing <yuehaibing@huawei.com>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: tegra: include linux/pinctrl/consumer.h
Date: Fri, 20 Sep 2019 16:18:45 +0100 [thread overview]
Message-ID: <20190920151845.GB10172@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <20190920150714.GK9720@e119886-lin.cambridge.arm.com>
On Fri, Sep 20, 2019 at 04:07:14PM +0100, Andrew Murray wrote:
> On Fri, Sep 20, 2019 at 04:55:05PM +0200, Arnd Bergmann wrote:
> > Without this, we can run into a build failure:
> >
> > drivers/pci/controller/dwc/pcie-tegra194.c:1394:8: error: implicit declaration of function 'pinctrl_pm_select_default_state' [-Werror,-Wimplicit-function-declaration]
> >
> > Fixes: ab2a50e7602b ("PCI: tegra: Add support to configure sideband pins")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Thanks for this. Another fix for this came in earlier today:
>
> https://patchwork.ozlabs.org/patch/1165139/
I have applied it since it came in earlier.
Thanks,
Lorenzo
> Reviewed-by: Andrew Murray <andrew.murray@arm.com>
>
> Thanks,
>
> Andrew Murray
>
> > ---
> > drivers/pci/controller/dwc/pcie-tegra194.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
> > index 09ed8e473cff..f89f5acee72d 100644
> > --- a/drivers/pci/controller/dwc/pcie-tegra194.c
> > +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
> > @@ -22,6 +22,7 @@
> > #include <linux/of_pci.h>
> > #include <linux/pci.h>
> > #include <linux/phy/phy.h>
> > +#include <linux/pinctrl/consumer.h>
> > #include <linux/platform_device.h>
> > #include <linux/pm_runtime.h>
> > #include <linux/random.h>
> > --
> > 2.20.0
> >
prev parent reply other threads:[~2019-09-20 15:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 14:55 [PATCH] PCI: tegra: include linux/pinctrl/consumer.h Arnd Bergmann
2019-09-20 15:07 ` Andrew Murray
2019-09-20 15:18 ` Lorenzo Pieralisi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190920151845.GB10172@e121166-lin.cambridge.arm.com \
--to=lorenzo.pieralisi@arm.com \
--cc=andrew.murray@arm.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=treding@nvidia.com \
--cc=vidyas@nvidia.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.