From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] name-rev: avoid cutoff timestamp underflow
Date: Mon, 23 Sep 2019 01:42:30 +0000 [thread overview]
Message-ID: <20190923012838.3hzai6ho7vjjhkpb@camp.crustytoothpaste.net> (raw)
In-Reply-To: <20190922180143.25026-1-szeder.dev@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 690 bytes --]
On 2019-09-22 at 18:01:43, SZEDER Gábor wrote:
> diff --git a/builtin/name-rev.c b/builtin/name-rev.c
> index c785fe16ba..a4d8d312ab 100644
> --- a/builtin/name-rev.c
> +++ b/builtin/name-rev.c
> @@ -9,7 +9,11 @@
> #include "sha1-lookup.h"
> #include "commit-slab.h"
>
> -#define CUTOFF_DATE_SLOP 86400 /* one day */
> +/*
> + * One day. See the 'name a rev close to epoch' test in t6120 when
This piece of code says "close to"…
> +test_expect_success 'name-rev a rev shortly after epoch' '
…but this says "shortly after."
Overall, I think the idea is definitely sane, though.
--
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 868 bytes --]
next prev parent reply other threads:[~2019-09-23 1:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-22 18:01 [PATCH] name-rev: avoid cutoff timestamp underflow SZEDER Gábor
2019-09-22 18:57 ` Phillip Wood
2019-09-22 19:53 ` SZEDER Gábor
2019-09-22 21:01 ` Johannes Sixt
2019-09-23 8:37 ` SZEDER Gábor
2019-09-23 9:30 ` Phillip Wood
2019-09-23 19:16 ` Johannes Sixt
2019-09-24 7:21 ` SZEDER Gábor
2019-09-23 1:42 ` brian m. carlson [this message]
2019-09-23 8:39 ` SZEDER Gábor
2019-09-24 7:32 ` SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190923012838.3hzai6ho7vjjhkpb@camp.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.