From: Andrew Morton <akpm@linux-foundation.org>
To: Joe Perches <joe@perches.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
Stephen Kitt <steve@sk2.org>, Kees Cook <keescook@chromium.org>,
Nitin Gote <nitin.r.gote@intel.com>,
jannh@google.com, kernel-hardening@lists.openwall.com,
Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Subject: Re: [PATCH V2 1/2] string: Add stracpy and stracpy_pad mechanisms
Date: Wed, 25 Sep 2019 14:50:11 -0700 [thread overview]
Message-ID: <20190925145011.c80c89b56fcee3060cf87773@linux-foundation.org> (raw)
In-Reply-To: <ed4611a4a96057bf8076856560bfbf9b5e95d390.1563889130.git.joe@perches.com>
On Tue, 23 Jul 2019 06:51:36 -0700 Joe Perches <joe@perches.com> wrote:
> Several uses of strlcpy and strscpy have had defects because the
> last argument of each function is misused or typoed.
>
> Add macro mechanisms to avoid this defect.
>
> stracpy (copy a string to a string array) must have a string
> array as the first argument (dest) and uses sizeof(dest) as the
> count of bytes to copy.
>
> These mechanisms verify that the dest argument is an array of
> char or other compatible types like u8 or s8 or equivalent.
>
> A BUILD_BUG is emitted when the type of dest is not compatible.
>
I'm still reluctant to merge this because we don't have code in -next
which *uses* it. You did have a patch for that against v1, I believe?
Please dust it off and send it along?
next prev parent reply other threads:[~2019-09-25 21:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 13:51 [PATCH V2 0/2] string: Add stracpy and stracpy_pad Joe Perches
2019-07-23 13:51 ` [PATCH V2 1/2] string: Add stracpy and stracpy_pad mechanisms Joe Perches
2019-07-23 14:37 ` Rasmus Villemoes
2019-07-23 15:39 ` Joe Perches
2019-07-23 15:39 ` Joe Perches
2019-07-24 6:53 ` Rasmus Villemoes
2019-07-24 7:10 ` Joe Perches
2019-07-24 7:10 ` Joe Perches
2019-09-25 21:50 ` Andrew Morton [this message]
2019-09-26 0:01 ` Stephen Kitt
2019-09-26 7:29 ` Rasmus Villemoes
2019-09-26 7:29 ` [alsa-devel] " Rasmus Villemoes
2019-09-26 8:25 ` Stephen Kitt
2019-09-26 8:51 ` Rasmus Villemoes
2019-09-26 8:51 ` [alsa-devel] " Rasmus Villemoes
2019-09-26 8:34 ` Joe Perches
2019-09-26 8:34 ` Joe Perches
2019-09-26 15:45 ` Kees Cook
2019-09-27 12:57 ` Julia Lawall
2019-09-27 12:57 ` Julia Lawall
2019-09-27 13:22 ` Julia Lawall
2019-09-27 13:22 ` Julia Lawall
2019-07-23 13:51 ` [PATCH V2 2/2] kernel-doc: core-api: Include string.h into core-api Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190925145011.c80c89b56fcee3060cf87773@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=jannh@google.com \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nitin.r.gote@intel.com \
--cc=rasmus.villemoes@prevas.dk \
--cc=steve@sk2.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.