Re: [PATCH v5 0/3] mfd: mc13xxx: Fixes and enhancements for NXP's mc34708

From: Lukasz Majewski <lukma@denx.de>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-kernel@vger.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Enrico Weigelt <info@metux.net>,
	Kate Stewart <kstewart@linuxfoundation.org>,
	linux-input@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v5 0/3] mfd: mc13xxx: Fixes and enhancements for NXP's mc34708
Date: Tue, 1 Oct 2019 10:19:09 +0200	[thread overview]
Message-ID: <20191001101909.79aacda0@jawa> (raw)
In-Reply-To: <20191001064130.GA11769@dell>

[-- Attachment #1: Type: text/plain, Size: 2815 bytes --]

Hi Lee,

> On Mon, 30 Sep 2019, Lukasz Majewski wrote:
> 
> > Dear Lee,
> >   
> > > This patch set provides several enhancements to mc13xxx MFD family
> > > of devices by introducing mc34708 as a separate device.
> > > 
> > > This IC has dedicated pen detection feature, which allows better
> > > touchscreen experience.
> > > 
> > > This is the fifth version of this code (v5).
> > > Discussion regarding previous versions can be found here:
> > > https://lkml.org/lkml/2018/4/12/351
> > > https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1661934.html
> > > https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1664296.html
> > > https://lkml.org/lkml/2019/7/17/705  
> > 
> > Gentle ping on this patch series. It is now 3 weeks without any
> > reply...  
> 
> Please take note and follow the kernel release cycle.
> 
> These patches were sent after the release of -rc7 i.e. very late
> in the release cycle and a point where most kernel maintainers stop
> reviewing/applying patches

Maybe something has changed recently, but I thought that the review is
an ongoing process (that the discussion about patches takes place all
the time to refine the code).

(and nobody expects maintainers pulling new patches after merge window).

> and start to prepare for the impending
> merge-window.
> 
> Also, there is no such thing as a gentle ping.

I'm a bit puzzled now. 
I do know that maintainers are overworked - and I do understand that.

However, NO reply for such a long time is at best confusing for
somebody who is willing to fix the kernel.

(Maybe this has changed too - but I do remember that there was a "rule
of thumb" to express any comment about the patch in 2 weeks time).

>  If you genuinely think
> your patches have unlikely("slipped though the gaps"), then post a
> [RESEND] complete with a note alluding your reasons doing such.
> 

Please forgive me, but are patches from this series eligible for pulling
(to v5.4 or even next release)?

> > > Sascha Hauer (3):
> > >   mfd: mc13xxx: Add mc34708 adc support
> > >   input: touchscreen mc13xxx: Make platform data optional
> > >   input: touchscreen mc13xxx: Add mc34708 support
> > > 
> > >  drivers/input/touchscreen/mc13783_ts.c | 63 ++++++++++++++---
> > >  drivers/mfd/mc13xxx-core.c             | 98
> > > +++++++++++++++++++++++++- include/linux/mfd/mc34708.h
> > > | 37 ++++++++++ 3 files changed, 185 insertions(+), 13
> > > deletions(-) create mode 100644 include/linux/mfd/mc34708.h  
> 

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]