From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andi Shyti <andi@etezian.org>
Cc: Stephan Gerhold <stephan@gerhold.net>,
Simon Shields <simon@lineageos.org>,
linux-input@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] Input: mms114 - add support for mms345l
Date: Wed, 9 Oct 2019 13:40:17 -0700 [thread overview]
Message-ID: <20191009204017.GK22365@dtor-ws> (raw)
In-Reply-To: <20191009072612.GA2814@jack.zhora.eu>
On Wed, Oct 09, 2019 at 10:26:12AM +0300, Andi Shyti wrote:
> Hi Dmitry,
>
> > > There was a related patch [2] that removes I2C_M_NOSTART for all models,
> > > but it seems abandoned and I do not have any other model for testing.
> > > Therefore, this patch implements the least instrusive solution
> > > and only removes I2C_M_NOSTART for MMS345L.
> >
> > Hmm, at this point I am inclined to pick up Andi's patch since it seems
> > to work for you and him and it looks like Android drivers are not using
> > I2C_M_NOSTART. I wonder if this was some quirk/big on the platform where
> > it was originally developed.
>
> I completely forgot about that patch :)
>
> I should refresh some old work on that device which was left
> undone.
>
> > Any objections?
>
> It's OK for me. If you can just update my e-mail, please, when
> applying the patch to "andi@etezian.org". Thanks!
Andi, any chance you could resend it with the new email? One thing that
I try to avoid modifying whenever I can is S-O-B strings...
Thanks.
--
Dmitry
next prev parent reply other threads:[~2019-10-09 20:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 20:33 [PATCH 0/3] Add support for Melfas MMS345L touchscreen Stephan Gerhold
2019-10-07 20:33 ` [PATCH 1/3] Input: mms114 - use device_get_match_data Stephan Gerhold
2019-10-08 11:44 ` Andi Shyti
2019-10-08 21:54 ` Dmitry Torokhov
2019-10-07 20:33 ` [PATCH 2/3] dt-bindings: mms114: document melfas,mms345l binding Stephan Gerhold
2019-10-08 11:45 ` Andi Shyti
2019-10-15 22:21 ` Rob Herring
2019-10-07 20:50 ` [PATCH 3/3] Input: mms114 - add support for mms345l Stephan Gerhold
2019-10-08 11:35 ` Andi Shyti
2019-10-08 11:44 ` Andi Shyti
2019-10-08 22:00 ` Dmitry Torokhov
2019-10-09 7:26 ` Andi Shyti
2019-10-09 20:40 ` Dmitry Torokhov [this message]
2019-10-13 21:39 ` Andi Shyti
2019-10-09 10:47 ` Stephan Gerhold
2019-10-13 21:04 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191009204017.GK22365@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=andi@etezian.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=simon@lineageos.org \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.