From: Kees Cook <keescook@chromium.org>
To: Aleksa Sarai <cyphar@cyphar.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Christian Brauner <christian@brauner.io>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Al Viro <viro@zeniv.linux.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
libc-alpha@sourceware.org, linux-api@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/4] lib: introduce copy_struct_from_user() helper
Date: Thu, 10 Oct 2019 09:43:26 -0700 [thread overview]
Message-ID: <201910100943.4C6AB66@keescook> (raw)
In-Reply-To: <20191010114007.o3bygjf4jlfk242e@yavin.dot.cyphar.com>
On Thu, Oct 10, 2019 at 10:40:07PM +1100, Aleksa Sarai wrote:
> Yeah, it takes about 5-10s on my laptop. We could switch it to just
> everything within a 4K block, but the main reason for testing with
> 2*PAGE_SIZE is to make sure that check_nonzero_user() works across page
> boundaries. Though we could only do check_nonzero_user() in the region
> of the page boundary (maybe i E (PAGE_SIZE-512,PAGE_SIZE+512]?)
Yeah, I like this idea: just poke at the specific edge-case.
--
Kees Cook
next prev parent reply other threads:[~2019-10-10 16:43 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 1:10 [PATCH v4 0/4] lib: introduce copy_struct_from_user() helper Aleksa Sarai
2019-10-01 1:10 ` [PATCH v4 1/4] " Aleksa Sarai
2019-10-01 1:58 ` Kees Cook
2019-10-01 2:31 ` Christian Brauner
2019-10-01 16:28 ` Kees Cook
2019-10-10 11:19 ` Michael Ellerman
2019-10-10 11:19 ` Michael Ellerman
2019-10-10 11:40 ` Aleksa Sarai
2019-10-10 16:43 ` Kees Cook [this message]
2019-10-11 2:24 ` [PATCH] usercopy: Avoid soft lockups in test_check_nonzero_user() Michael Ellerman
2019-10-11 3:48 ` Aleksa Sarai
2019-10-11 9:43 ` Christian Brauner
2019-10-16 12:28 ` Michael Ellerman
2019-10-16 12:45 ` Christian Brauner
2019-10-12 9:54 ` Michael Ellerman
2019-10-12 10:12 ` Aleksa Sarai
2019-10-16 12:27 ` [PATCH v2] " Michael Ellerman
2019-10-16 12:36 ` Aleksa Sarai
2019-10-16 12:50 ` Christian Brauner
2019-10-16 13:03 ` Christian Brauner
2019-10-16 22:00 ` Michael Ellerman
2019-10-17 6:09 ` Christian Brauner
2019-10-23 2:23 ` Michael Ellerman
2019-10-01 1:10 ` [PATCH v4 2/4] clone3: switch to copy_struct_from_user() Aleksa Sarai
2019-10-01 2:32 ` Christian Brauner
2019-10-01 1:10 ` [PATCH v4 3/4] sched_setattr: " Aleksa Sarai
2019-10-01 2:33 ` Christian Brauner
2019-10-01 1:10 ` [PATCH v4 4/4] perf_event_open: " Aleksa Sarai
2019-10-01 2:36 ` Christian Brauner
2019-10-01 16:01 ` [PATCH v4 0/4] lib: introduce copy_struct_from_user() helper Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201910100943.4C6AB66@keescook \
--to=keescook@chromium.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=christian@brauner.io \
--cc=cyphar@cyphar.com \
--cc=jolsa@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.