From: Thomas Gummerer <t.gummerer@gmail.com>
To: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 1/1] doc(stash): clarify the description of `save`
Date: Thu, 10 Oct 2019 11:28:28 +0100 [thread overview]
Message-ID: <20191010102828.GA12497@cat> (raw)
In-Reply-To: <572c7d0c51ffc68dc4603752d05fa7a418dbdd71.1570702000.git.gitgitgadget@gmail.com>
On 10/10, Johannes Schindelin via GitGitGadget wrote:
> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> The original phrasing of this paragraph made at least one person stumble
> over the word "from" (thinking that it was a typo and "from" was
> intended), and other readers chimed in, agreeing that it was confusing:
> https://public-inbox.org/git/0102016b8d597569-c1f6cfdc-cb45-4428-8737-cb1bc30655d8-000000@eu-west-1.amazonses.com/#t
>
> Let's rewrite that paragraph for clarity.
>
> Inspired-by-a-patch-by: Catalin Criste <cris_linu_w@yahoo.com>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Thanks for picking this thread up again, I had already forgotten about
it. The updated wording sounds like an improvement to me.
> ---
> Documentation/git-stash.txt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/git-stash.txt b/Documentation/git-stash.txt
> index 8fbe12c66c..53e1a1205d 100644
> --- a/Documentation/git-stash.txt
> +++ b/Documentation/git-stash.txt
> @@ -87,8 +87,9 @@ The `--patch` option implies `--keep-index`. You can use
> save [-p|--patch] [-k|--[no-]keep-index] [-u|--include-untracked] [-a|--all] [-q|--quiet] [<message>]::
>
> This option is deprecated in favour of 'git stash push'. It
> - differs from "stash push" in that it cannot take pathspecs,
> - and any non-option arguments form the message.
> + differs from "stash push" in that it cannot take pathspecs.
> + Instead, all non-option arguments are concatenated to form the stash
> + message.
>
> list [<options>]::
>
> --
> gitgitgadget
next prev parent reply other threads:[~2019-10-10 10:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 10:06 [PATCH 0/1] Make the description of git stash save clearer Johannes Schindelin via GitGitGadget
2019-10-10 10:06 ` [PATCH 1/1] doc(stash): clarify the description of `save` Johannes Schindelin via GitGitGadget
2019-10-10 10:28 ` Thomas Gummerer [this message]
2019-10-11 5:29 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191010102828.GA12497@cat \
--to=t.gummerer@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.