From: Rob Herring <robh@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v3 8/8] dt-bindings: Add max12xx SPI ADC series as trivial devices
Date: Thu, 10 Oct 2019 15:47:51 -0500 [thread overview]
Message-ID: <20191010204751.GA22206@bogus> (raw)
In-Reply-To: <20191007132657.4190-9-miquel.raynal@bootlin.com>
On Mon, Oct 07, 2019 at 03:26:57PM +0200, Miquel Raynal wrote:
> Update the compatible list with three Maxim ADCs compatibles.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
> .../bindings/iio/adc/max1027-adc.txt | 28 +++++++++++++++++++
> .../devicetree/bindings/trivial-devices.yaml | 6 ++++
> 2 files changed, 34 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/max1027-adc.txt
Devices are supposed to be documented in one place or the other. So
either make max1027-adc.txt a schema or drop it.
I'm fine either way. Obviously, trivial-devices.yaml is trivial to add
to, but it does leave some ambiguities. Like is an interrupt required,
optional or non-existent? What about power supplies? Or what are allowed
values for spi-max-frequency.
Rob
next prev parent reply other threads:[~2019-10-10 20:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 13:26 [PATCH v3 0/8] Introduce max12xx ADC support Miquel Raynal
2019-10-07 13:26 ` Miquel Raynal
2019-10-07 13:26 ` [PATCH v3 1/8] iio: adc: max1027: Add debugfs register read support Miquel Raynal
2019-10-07 13:26 ` Miquel Raynal
2019-10-07 13:26 ` [PATCH v3 2/8] iio: adc: max1027: Make it optional to use interrupts Miquel Raynal
2019-10-07 13:26 ` Miquel Raynal
2019-10-07 13:26 ` [PATCH v3 3/8] iio: adc: max1027: Reset the device at probe time Miquel Raynal
2019-10-07 13:26 ` Miquel Raynal
2019-10-07 13:26 ` [PATCH v3 4/8] iio: adc: max1027: Prepare the introduction of different resolutions Miquel Raynal
2019-10-07 13:26 ` Miquel Raynal
2019-10-07 13:26 ` [PATCH v3 5/8] iio: adc: max1027: Introduce 12-bit devices support Miquel Raynal
2019-10-07 13:26 ` Miquel Raynal
2019-10-07 13:26 ` [PATCH v3 6/8] dt-bindings: iio: adc: max1027: Mark interrupts as optional Miquel Raynal
2019-10-07 13:26 ` Miquel Raynal
2019-10-07 13:26 ` [PATCH v3 7/8] dt-bindings: Add 1027/1029/1031 SPI ADCs as trivial devices Miquel Raynal
2019-10-07 13:26 ` Miquel Raynal
2019-10-07 13:26 ` [PATCH v3 8/8] dt-bindings: Add max12xx SPI ADC series " Miquel Raynal
2019-10-07 13:26 ` Miquel Raynal
2019-10-10 20:47 ` Rob Herring [this message]
2019-10-10 21:31 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191010204751.GA22206@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=miquel.raynal@bootlin.com \
--cc=pmeerw@pmeerw.net \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.