From: Anthony PERARD <anthony.perard@citrix.com>
To: Ian Jackson <ian.jackson@citrix.com>
Cc: "Jürgen Groß" <jgross@suse.com>, "Wei Liu" <wl@xen.org>,
"Andrew Cooper" <Andrew.Cooper3@citrix.com>,
"George Dunlap" <dunlapg@umich.edu>,
"Paul Durrant" <pdurrant@gmail.com>,
"Jan Beulich" <jbeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic
Date: Mon, 14 Oct 2019 17:59:26 +0100 [thread overview]
Message-ID: <20191014165926.GB1138@perard.uk.xensource.com> (raw)
In-Reply-To: <23972.40372.377662.700932@mariner.uk.xensource.com>
On Mon, Oct 14, 2019 at 05:09:24PM +0100, Ian Jackson wrote:
> Paul Durrant writes ("Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic"):
> > On Fri, 11 Oct 2019 at 17:34, Ian Jackson <ian.jackson@citrix.com> wrote:
> > >
> > > Jürgen Groß writes ("Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic"):
> > > > On 11.10.19 15:31, Ian Jackson wrote:
> > > > > I do not have a strong opinion about this. I would be happy with
> > > > > "auto" (or "default" maybe).
> > > >
> > > > "unspecified"?
> > >
> > > That is IMO the best suggestion so far so I will go with that in my
> > > v3.
> >
> > Seems odd to specify a parameter with a value of 'unspecified' ;-)
>
> I have tried to infer +1/-1/0 numbers from the mail thread. I have
> also looked at libxl_types.idl to see how many times we are using
> what name to represent roughly this concept:
>
> Bikeshed colour Paul Juergen George Ian Anthony Wei #already
>
> unknown ? ? -1 +2 ? ? 17
> default ? ? ? 0 ? ? 2
> auto -1 ? +1 0 ? ? 1
> unspecified -1 +1 ? 0 ? ? 0
>
> ^^^^^^^^^^^^^^^^
> libxl maintainers
Maybe "unknown" is more used in the API, but when I look at the manpage
"unknown" value as never been used before. On the other hand "default"
as been used twice in the man page. (and one "defaults" and two other
"default" that I'm not sure if they can be in the config file.)
So I would say +2 for default and +1 for unknown.
--
Anthony PERARD
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-10-14 16:59 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 15:11 [Xen-devel] [XEN PATCH for-4.13 v2 0/9] libxl memkb & pt defaulting Ian Jackson
2019-10-10 15:11 ` [Xen-devel] [XEN PATCH for-4.13 v2 1/9] libxl: Offer API versions 0x040700 and 0x040800 Ian Jackson
2019-11-25 18:44 ` Jim Fehlig
2019-10-10 15:11 ` [Xen-devel] [XEN PATCH for-4.13 v2 2/9] xl: Pass libxl_domain_config to freemem(), instead of b_info Ian Jackson
2019-10-10 15:11 ` [Xen-devel] [XEN PATCH for-4.13 v2 3/9] libxl: libxl__domain_config_setdefault: New function Ian Jackson
2019-10-10 15:11 ` [Xen-devel] [XEN PATCH for-4.13 v2 4/9] libxl: libxl_domain_need_memory: Make it take a domain_config Ian Jackson
2019-10-10 15:11 ` [Xen-devel] [XEN PATCH for-4.13 v2 5/9] libxl: Move shadow_memkb and iommu_memkb defaulting into libxl Ian Jackson
2019-10-10 15:11 ` [Xen-devel] [XEN PATCH for-4.13 v2 6/9] libxl: Remove/deprecate libxl_get_required_*_memory from the API Ian Jackson
2019-10-10 15:11 ` [Xen-devel] [XEN PATCH for-4.13 v2 7/9] libxl: create: setdefault: Make libxl_physinfo info[1] Ian Jackson
2019-10-11 9:26 ` Wei Liu
2019-10-10 15:11 ` [Xen-devel] [XEN PATCH for-4.13 v2 8/9] libxl: create: setdefault: Move physinfo into config_setdefault Ian Jackson
2019-10-11 9:26 ` Wei Liu
2019-10-10 15:11 ` [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic Ian Jackson
2019-10-11 9:26 ` Wei Liu
2019-10-11 9:47 ` Andrew Cooper
2019-10-11 10:10 ` Ian Jackson
2019-10-11 11:00 ` Julien Grall
2019-10-11 13:33 ` Ian Jackson
2019-10-11 12:23 ` George Dunlap
2019-10-11 13:31 ` Ian Jackson
2019-10-11 13:55 ` Jürgen Groß
2019-10-11 16:34 ` Ian Jackson
2019-10-14 7:59 ` Paul Durrant
2019-10-14 16:09 ` Ian Jackson
2019-10-14 16:44 ` Wei Liu
2019-10-14 16:48 ` Ian Jackson
2019-10-14 16:51 ` [Xen-devel] [XEN PATCH v4 for-4.13 10/10] libxl/xl: Overhaul passthrough setting logic " Ian Jackson
2019-10-14 17:06 ` Anthony PERARD
2019-10-14 16:59 ` Anthony PERARD [this message]
2019-10-15 11:13 ` [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul " Wei Liu
2019-10-10 15:18 ` [Xen-devel] [XEN PATCH for-4.13 v2 0/9] libxl memkb & pt defaulting Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014165926.GB1138@perard.uk.xensource.com \
--to=anthony.perard@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=dunlapg@umich.edu \
--cc=ian.jackson@citrix.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=pdurrant@gmail.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.